fix: remove project specific network deprecation warning #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested review from
chenyan-dfinity and
a team
as code owners
ericswanson-dfinity
changed the title
lwshang
approved these changes
Sep 19, 2023
mergify
bot
deleted the
remove-project-specific-network-deprecation-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running
dfx startwith a project-specific network (dfx.json contains alocalnetwork definition), dfx displays the following warning:It's mid-September, which is not a good look, but also we shouldn't remove project-specific networks until we can support multiple subnet types at the same time.
How Has This Been Tested?
Ran
dfx startin a directory where dfx.json defined a local network.Checklist: