refactor: always fetch did file from canister when making canister calls #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested changes
Feb 21, 2023
Co-authored-by: Eric Swanson <[email protected]>
ericswanson-dfinity
approved these changes
Jan 22, 2024
auto-merge was automatically disabled
January 23, 2024 02:35
Pull Request is not mergeable
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactor enables
dfx canister callto always fetch did file from the canister metadata. This is especially helpful for remote canister.Note that
dfx canister signis still following the old logic, becausesignis running in offline mode and cannot access the network.This is also a pre-requisite of the candid assist feature.
How Has This Been Tested?
Existing tests should cover this refactor.
Checklist: