Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch did file from canister metadata #3558

Merged
merged 13 commits into from
Feb 7, 2024
Merged

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Jan 31, 2024

Description

Enables dfx canister call to always fetch did file from the canister metadata. Add a deprecation warning when metadata is not available.

Same as #2931 but with deprecation warning.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@chenyan-dfinity chenyan-dfinity marked this pull request as ready for review January 31, 2024 20:19
@chenyan-dfinity chenyan-dfinity requested a review from a team as a code owner January 31, 2024 20:19
CHANGELOG.md Outdated Show resolved Hide resolved
e2e/tests-dfx/call.bash Outdated Show resolved Hide resolved
src/dfx/src/commands/canister/call.rs Outdated Show resolved Hide resolved
src/dfx/src/commands/canister/call.rs Outdated Show resolved Hide resolved
@chenyan-dfinity chenyan-dfinity enabled auto-merge (squash) February 6, 2024 23:56
@chenyan-dfinity chenyan-dfinity merged commit e7076f7 into master Feb 7, 2024
169 checks passed
@chenyan-dfinity chenyan-dfinity deleted the call-metadata branch February 7, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants