Remove separate uploading of assets from deploy-to-app.yaml #5558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
# Motivation This code was added in #2632 to support deploying the NNS dapp WASM in chunks to an application subnet. Deploying large WASMs in chunks is now natively supported by `dfx` and we rely on this since #5558 So this custom code is no longer needed. # Changes Remove the code added in #2632 # Tests Also removed. # Todos - [ ] Add entry to changelog (if necessary). not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The nns-dapp wasm is bigger than 2 MB. When the
deploy-to-appworkflow was created, this meant that the wasm couldn't be installed to an application subnet.The "real" nns-dapp isn't affected by this because the NNS subnet allows larger messages.
To work around this, a mechanism was implemented to build and install a wasm without assets and upload the assets separately.
This is no longer necessary because the IC now supports uploading the wasm in chunks and then installing the wasm from chunks.
dfxalso supports this transparently.So we can simply call
dfxto install the large wasm and everything happens correctly behind the scenes.Changes
noassetswasm.Tests
https://beta.nns.ic0.app/ is working again because it was installed and upgraded this way:
Todos
not necessary