Remove asset uploading code #5615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrasinskis
approved these changes
Oct 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
# Motivation The `split-assets` script was used to create asset chunks to upload to an nns-dapp wasm that was deployed without assets. This functionality was remove in #5615 so there is no need anymore for this script. # Changes Remove `scripts/nns-dapp/split-assets`. # Tests 1. Remove `scripts/nns-dapp/split-assets.test`. 2. Stop running `scripts/nns-dapp/split-assets.test` in `.github/workflows/checks.yml`. # Todos - [ ] Add entry to changelog (if necessary). not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This code was added in #2632 to support deploying the NNS dapp WASM in chunks to an application subnet.
Deploying large WASMs in chunks is now natively supported by
dfxand we rely on this since #5558So this custom code is no longer needed.
Changes
Remove the code added in #2632
Tests
Also removed.
Todos
not necessary