Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ic-js for subnet rental topic #4864

Merged
merged 4 commits into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-Nns-Dapp-unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ proposal is successful, the changes it released will be moved from this file to
* Close modal on ESC key press.
* Add `ENABLE_ACTIONABLE_TAB` feature flag.
* Support `ApiBoundaryNodes` in `FirewallRulesScope` of `AddFirewallRulesPayload`.
* Support `SubnetRental` topic.
* Support NNS function 52 for `SubnetRentalRequest`.

#### Changed
Expand Down
96 changes: 48 additions & 48 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions frontend/src/lib/i18n/en.governance.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
"ReplicaVersionManagement": "IC OS Version Election",
"SubnetReplicaVersionManagement": "IC OS Version Deployment",
"SnsAndCommunityFund": "SNS & Neurons' Fund",
"ApiBoundaryNodeManagement": "API Boundary Node Management"
"ApiBoundaryNodeManagement": "API Boundary Node Management",
"SubnetRental": "Subnet Rental"
},
"topics_description": {
"Unspecified": "",
Expand All @@ -40,7 +41,8 @@
"ReplicaVersionManagement": "Proposals handling election of IC OS versions.",
"SubnetReplicaVersionManagement": "Proposals handling deployments of IC OS versions.",
"SnsAndCommunityFund": "Proposals relating to service nervous systems (SNS) and Neurons' Fund.",
"ApiBoundaryNodeManagement": "Proposals related to the management of API boundary nodes."
"ApiBoundaryNodeManagement": "Proposals related to the management of API boundary nodes.",
"SubnetRental": "All proposals related to renting a subnet — for example a subnet rental request."
},
"rewards": {
"Unknown": "Unknown",
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/lib/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,8 @@
"topic_14_subtitle": "Proposals related to SNS and Neurons' Fund",
"topic_15_title": "API Boundary Node Management",
"topic_15_subtitle": "Proposals related to the management of API boundary nodes",
"topic_16_title": "Subnet Rental",
"topic_16_subtitle": "All proposals related to renting a subnet, for example a subnet rental request.",
"current_followees": "Currently Following",
"add": "Add Followee"
},
Expand Down
4 changes: 4 additions & 0 deletions frontend/src/lib/types/i18n.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,8 @@ interface I18nFollow_neurons {
topic_14_subtitle: string;
topic_15_title: string;
topic_15_subtitle: string;
topic_16_title: string;
topic_16_subtitle: string;
current_followees: string;
add: string;
}
Expand Down Expand Up @@ -1104,6 +1106,7 @@ interface I18nTopics {
SubnetReplicaVersionManagement: string;
SnsAndCommunityFund: string;
ApiBoundaryNodeManagement: string;
SubnetRental: string;
}

interface I18nTopics_description {
Expand All @@ -1123,6 +1126,7 @@ interface I18nTopics_description {
SubnetReplicaVersionManagement: string;
SnsAndCommunityFund: string;
ApiBoundaryNodeManagement: string;
SubnetRental: string;
}

interface I18nRewards {
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/lib/utils/neuron.utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1003,6 +1003,7 @@ export const getTopicTitle = ({
[Topic.ReplicaVersionManagement]: i18n.follow_neurons.topic_13_title,
[Topic.SnsAndCommunityFund]: i18n.follow_neurons.topic_14_title,
[Topic.ApiBoundaryNodeManagement]: i18n.follow_neurons.topic_15_title,
[Topic.SubnetRental]: i18n.follow_neurons.topic_16_title,
};
return mapper[topic];
};
Expand Down Expand Up @@ -1032,6 +1033,7 @@ export const getTopicSubtitle = ({
[Topic.ReplicaVersionManagement]: i18n.follow_neurons.topic_13_subtitle,
[Topic.SnsAndCommunityFund]: i18n.follow_neurons.topic_14_subtitle,
[Topic.ApiBoundaryNodeManagement]: i18n.follow_neurons.topic_15_subtitle,
[Topic.SubnetRental]: i18n.follow_neurons.topic_16_subtitle,
};
return mapper[topic];
};
1 change: 1 addition & 0 deletions frontend/src/tests/lib/utils/enum.utils.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ describe("enum-utils", () => {
Topic.ReplicaVersionManagement,
Topic.SnsAndCommunityFund,
Topic.ApiBoundaryNodeManagement,
Topic.SubnetRental,
];

expect(
Expand Down
6 changes: 6 additions & 0 deletions frontend/src/tests/lib/utils/neuron.utils.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2751,6 +2751,9 @@ describe("neuron-utils", () => {
expect(
getTopicTitle({ topic: Topic.ApiBoundaryNodeManagement, i18n: en })
).toBe("API Boundary Node Management");
expect(getTopicTitle({ topic: Topic.SubnetRental, i18n: en })).toBe(
"Subnet Rental"
);
});
});

Expand Down Expand Up @@ -2825,6 +2828,9 @@ describe("neuron-utils", () => {
expect(
getTopicSubtitle({ topic: Topic.ApiBoundaryNodeManagement, i18n: en })
).toBe("Proposals related to the management of API boundary nodes");
expect(getTopicSubtitle({ topic: Topic.SubnetRental, i18n: en })).toBe(
"All proposals related to renting a subnet, for example a subnet rental request."
);
});
});
});