Bump ic-js for subnet rental topic #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrasinskis
approved these changes
May 14, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 14, 2024
# Motivation When adding a new topic in #4864 all tests passed but trying to add a followee for the new topic gave an error before the governance canister was updated. Things shouldn't be broken when all tests are passing so we need a test for this. # Changes 1. Add an e2e test which tries to add a followee for every existing topic. 2. Add page objects. 3. Add test IDs. # Tests Tested it with a snapshot that does not have the new topic and ic-js version that does have the new topic and saw the test fail. # Todos - [ ] Add entry to changelog (if necessary). not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pull in the
SubnetRentaltopic from dfinity/ic-js#627Changes
npm run upgrade:nextTests
Todos