Upgrade agent-js #2446
Merged
Upgrade agent-js #2446
+39
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR upgrades `agent-js` to the latest version because it includes an improvement to the errors thrown when failing to decode cbor.
|
If interesting, in ic-js I did not upgraded yet agent-js because an issue was reported: I asked @krpeacock if the related patch would be merged soon but, it seems to not have been patched yet so, I'm still waiting. Don't know though if the issue is a blocker or a race condition in some particular use case. |
|
@peterpeterparker: Thanks for your input. I'll merge this and then set the retry count to 10 in the agent, which seems to fix this (albeit in an inelegant way). |
frederikrothenberger
pushed a commit
that referenced
this pull request
Apr 26, 2024
This PR configures the number of retries to 10 (as opposed to just 3, which is the default). This makes the agent more resilient against watermark check failures, because the likelihood of hitting only replicas that are behind gets lowered a lot and retrying takes time too. Addresses [this comment](#2446 (comment)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
Configure up to 10 retries on agnet failure This PR configures the number of retries to 10 (as opposed to just 3, which is the default). This makes the agent more resilient against watermark check failures, because the likelihood of hitting only replicas that are behind gets lowered a lot and retrying takes time too. Addresses [this comment](#2446 (comment)).
|
Yeah, it's taken me longer than I intended, and I still don't have it working against prod. Having the conference come up didn't help either |
peterpeterparker
added a commit
to dfinity/ic-js
that referenced
this pull request
Apr 29, 2024
# Motivation The migration to pure JS BLS verification in agent-js v1.2.0 has a notable impact on bundle size (roughly -15% according [forum post](https://forum.dfinity.org/t/agent-js-1-2-0-is-released/28881/2?u=peterparker)). Therefore it makes sense to promote those changes. # Notes To prevent the issue reported on the [forum](https://forum.dfinity.org/t/timestamp-failed-to-pass-the-watermark-after-retrying-the-configured-3-times/29180/3?u=peterparker) to happen, the number of retry for the agent has been set to 10 similiar has what was done in II (see [PR](dfinity/internet-identity#2446)) # Changes - `npm run update:agent` - set number of retry to 10 and expose a parameter to tweak the value if required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
agent-jsto the latest version because it includes an improvement to the errors thrown when failing to decode cbor.🟡 Some screens were changed