Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: agent-js v1.2.1 #593

Merged
merged 11 commits into from
Apr 29, 2024
Merged

build: agent-js v1.2.1 #593

merged 11 commits into from
Apr 29, 2024

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Mar 27, 2024 •
edited
Loading

Motivation

The migration to pure JS BLS verification in agent-js v1.2.0 has a notable impact on bundle size (roughly -15% according forum post). Therefore it makes sense to promote those changes.

Notes

To prevent the issue reported on the forum to happen, the number of retry for the agent has been set to 10 similiar has what was done in II (see PR)

Changes

  • npm run update:agent
  • set number of retry to 10 and expose a parameter to tweak the value if required

@peterpeterparker
build: agent-js v1.2.0
ea5b478 
Signed-off-by: David Dal Busco <[email protected]>
@peterpeterparker peterpeterparker marked this pull request as draft March 27, 2024 07:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2024 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 7.24 KB (-0.69% 🔽)
@dfinity/cketh 2.83 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.42 KB (0%)
@dfinity/ledger-icp 14.73 KB (-0.3% 🔽)
@dfinity/nns 34.34 KB (-0.26% 🔽)
@dfinity/nns-proto 76.44 KB (0%)
@dfinity/sns 15.62 KB (-0.35% 🔽)
@dfinity/utils 4.45 KB (+0.29% 🔺)
@dfinity/ic-management 2.61 KB (0%)

@peterpeterparker
chore: merge main
af1ad76 
Signed-off-by: David Dal Busco <[email protected]>
@peterpeterparker peterpeterparker marked this pull request as ready for review April 1, 2024 05:40
@peterpeterparker
docs: agent-js v1.2.0
8f35a4b 
Signed-off-by: David Dal Busco <[email protected]>
lmuntaner
lmuntaner approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker
Copy link
Member Author

On hold until agent-js dfinity/agent-js#871 is resolved following issue reported by developers on the forum.

@peterpeterparker peterpeterparker marked this pull request as draft April 3, 2024 06:11
@peterpeterparker peterpeterparker mentioned this pull request Apr 8, 2024
Merged
@peterpeterparker peterpeterparker mentioned this pull request Apr 26, 2024
Merged
@peterpeterparker peterpeterparker marked this pull request as ready for review April 29, 2024 04:25
@peterpeterparker peterpeterparker changed the title build: agent-js v1.2.0 build: agent-js v1.2.1 Apr 29, 2024
lmuntaner
lmuntaner approved these changes Apr 29, 2024
View reviewed changes
packages/utils/src/utils/agent.utils.ts Outdated Show resolved Hide resolved
@peterpeterparker peterpeterparker merged commit b1d8555 into main Apr 29, 2024
10 checks passed
@peterpeterparker peterpeterparker deleted the build/agent-js-v1.2.0 branch April 29, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @lmuntaner