feat: CMC get default subnets #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <[email protected]>
size-limit report 📦
|
peterpeterparker
added a commit
that referenced
this pull request
Oct 14, 2024
# Motivation In PR #733 I would like to implement a function for the CMC canister that can be called as `query` or `update` call. The `CMCCanister` does not yet support the service binding for query and it's `create` implementation differs from the standards. That's why this PR update the create function to use the standard utility `createServices`. # Changes - Update `CMCCanister.create` to use the standardized function. - Deprecate the use of `string` as creation option for consistency reasons. # Tests The tests were already using a `canisterId` set as `Principal`. --------- Signed-off-by: David Dal Busco <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
…to feat/cmc-get-default-subnets
Signed-off-by: David Dal Busco <[email protected]>
dskloetd
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Particularly those days when the subnets are overloaded, it can be interesting for devs to be able to programmatically get a list of subnets. Therefore, this PR exposes the function
get_default_subnetsof the CMC canister.Changes
get_default_subnetsinCMCCanister.