feat: CMC create standardized to support query #734
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In PR #733 I would like to implement a function for the CMC canister that can be called as
query
orupdate
call. TheCMCCanister
does not yet support the service binding for query and it'screate
implementation differs from the standards.That's why this PR update the create function to use the standard utility
createServices
.Changes
CMCCanister.create
to use the standardized function.string
as creation option for consistency reasons.Tests
The tests were already using a
canisterId
set asPrincipal
.