Add SubnetRental to Topic enum #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
peterpeterparker
approved these changes
May 14, 2024
1 task
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
May 14, 2024
# Motivation Pull in the `SubnetRental` topic from dfinity/ic-js#627 # Changes 1. Ran `npm run upgrade:next` 2. Updated mapping code and tests to take the new topic enum into account. # Tests 1. Unit tests updated. 2. Manually tested filtering proposals by "Subnet Rental" topic and adding followees to "Subnet Rental". # Todos - [x] Add entry to changelog (if necessary).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The new proposal type to rent subnets, has its own topic.
Changes
Add topic
SubnetRentaltoTopicenum.Tests
not tested
Todos