Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ckbtc candid #476

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Update ckbtc candid #476

merged 3 commits into from
Nov 20, 2023

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Nov 20, 2023

Motivation

Make PendingUtxo candid type available.

Changes

Automated

  1. In ~/gitlab/ic run git checkout 4de99bc27be74048f80d13200f3c75cf2a43438c
  2. In ic-js run:
$ scripts/import-candid ~/gitlab/ic
$ scripts/compile-idl-js
$ git checkout packages/{cmc,ic-management,ledger-icp,ledger-icrc,nns,sns}

Manual

Fixed packages/ckbtc/src/minter.canister.spec.ts to include pending_utxos as an empty array.
Optional fields are not really optional in TypeScript generated from Candid.

Tests

In ic-js:

npm ci
npm run build --workspace packages/utils && \
  npm run build --workspace packages/nns-proto &&
  npm run build --workspace packages/ledger-icrc && \
  npm run build --workspace packages/ledger-icp && \
  npm run build --workspaces

In nns-dapp:

cd frontend
rm -rf node_modules
npm ci

for x in utils ckbtc; do
  npm rm @dfinity/$x && npm i $IC_JS_PATH/packages/$x
done

Then tested manually that things look find without errors.

Todos

  • Add entry to changelog (if necessary).

Copy link
Contributor

github-actions bot commented Nov 20, 2023

size-limit report 📦

Path Size
@dfinity/ckbtc 6.81 KB (+0.35% 🔺)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (0%)
@dfinity/ledger-icp 14.41 KB (0%)
@dfinity/nns 33.82 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.92 KB (0%)
@dfinity/utils 4.12 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

@dskloetd dskloetd requested a review from lmuntaner November 20, 2023 13:51
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

},
},
} as UpdateBalanceError,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either this or as [] after pending_utxos: [].
This seemed more future proof.

@dskloetd dskloetd merged commit 7e3208c into main Nov 20, 2023
10 checks passed
@dskloetd dskloetd deleted the kloet/bump-ckbtc branch November 20, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants