-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
# Motivation Make `PendingUtxo` candid type available. # Changes ## Automated 1. In `~/gitlab/ic` run `git checkout 4de99bc27be74048f80d13200f3c75cf2a43438c` 2. In `ic-js` run: ``` $ scripts/import-candid ~/gitlab/ic $ scripts/compile-idl-js $ git checkout packages/{cmc,ic-management,ledger-icp,ledger-icrc,nns,sns} ``` ## Manual Fixed `packages/ckbtc/src/minter.canister.spec.ts` to include `pending_utxos` as an empty array. Optional fields are not really optional in TypeScript generated from Candid. # Tests In ic-js: ``` npm ci npm run build --workspace packages/utils && \ npm run build --workspace packages/nns-proto && npm run build --workspace packages/ledger-icrc && \ npm run build --workspace packages/ledger-icp && \ npm run build --workspaces ``` In nns-dapp: ``` cd frontend rm -rf node_modules npm ci for x in utils ckbtc; do npm rm @dfinity/$x && npm i $IC_JS_PATH/packages/$x done ``` Then tested manually that things look find without errors. # Todos - [x] Add entry to changelog (if necessary).
- Loading branch information
Showing
6 changed files
with
31 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters