feat: copy ICP ledger-related features to new ledger-icp library #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
added
the
breaking_changes
|
@lmuntaner settings this PR as draft only because we might want to publish a release before merging this one. |
…nto feat/move-ledger-icp-features
lmuntaner
reviewed
Sep 27, 2023
|
@lmuntaner as we discussed doing it in two PRs for ledger-icrc, let's do it here also in two PRs.
|
peterpeterparker
changed the title
size-limit report 📦
|
…nto feat/move-ledger-icp-features
peterpeterparker
added a commit
that referenced
this pull request
Oct 2, 2023
# Motivation This PR effectively removes the ledger from the library `@dfinity/nns` as related features were moved to `@dfinity/ledger-icp` in #427. # Changes - remove files - bump v2.0.0 - use `@dfinity/ledger-icp` as peer dependency for few utils and types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Community and developers are confused about what ledger and interfaces to use in which context. That's why we decided to makes it more clear that interfacing with ICP requires a specific library even though it supports ICRC-1. The idea is to have a generic ICRC-1 ledger lib and one dedicated to ICP.
That's why we are creating a new library and moving all ledger ICP related code from
@dfinity/nnsto@dfinity/ledger-icp.Notes
AccountIdentifierinstead of using a type declared in the Governance candid file to returns a hash as Unit8Array, I used an object that contains the primitive type as declaration.ledger-icpand a future PR will remove the duplication innnsICPto definitely ultimately remove it