Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove ICP ledger-related features from nns #433

Merged
merged 13 commits into from
Oct 2, 2023

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Oct 2, 2023

Motivation

This PR effectively removes the ledger from the library @dfinity/nns as related features were moved to @dfinity/ledger-icp in #427.

Changes

  • remove files
  • bump v2.0.0
  • use @dfinity/ledger-icp as peer dependency for few utils and types

@peterpeterparker peterpeterparker added the breaking_changes New feature or issue that results in breaking changes label Oct 2, 2023
@peterpeterparker peterpeterparker marked this pull request as ready for review October 2, 2023 11:18
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

size-limit report 📦

Path Size
@dfinity/ckbtc 6.38 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger 2.92 KB (0%)
@dfinity/ledger-icp 14.17 KB (0%)
@dfinity/nns 29.52 KB (-0.92% 🔽)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.85 KB (0%)
@dfinity/utils 3.81 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker peterpeterparker merged commit 667d507 into main Oct 2, 2023
9 checks passed
@peterpeterparker peterpeterparker deleted the feat/remove-ledger-nns branch October 2, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_changes New feature or issue that results in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants