-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow option set agent replica time #923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
krpeacock
changed the title
feat: allow option to sync with replica time using errors
feat: allow option set agent replica time
Sep 11, 2024
lwshang
approved these changes
Sep 11, 2024
ghost
mentioned this pull request
Sep 27, 2024
ghost
pushed a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new feature to set and read a specified
replicaTime
on theHttpAgent
. This is useful in situations where the device clock may not be accurate, such as in an airgapped device, since the agent needs to agree with the replica when creating anExpiry
or validating certificates.Also improves the error handling for replica time errors, throwing a new
ReplicaTimeError
, containing a reference back to theagent
that threw it, as well as a parsedreplicaTime
Date object from the error message.This replaces the
offset
strategy previously used.examples
Important: the error response cannot be certified. Using it directly could subject users to replay attacks
Fixes SDK-1812
How Has This Been Tested?
New e2e tests
Checklist: