Revert "feat: allow option set agent replica time (#923)"

This reverts commit a973a4d.

e2e/node/basic/mainnet.test.ts

@@ -7,7 +7,6 @@ import {
   fromHex,
   polling,
   requestIdOf,
-  ReplicaTimeError,
 } from '@dfinity/agent';
 import { IDL } from '@dfinity/candid';
 import { Ed25519KeyIdentity } from '@dfinity/identity';
@@ -22,7 +21,7 @@ const createWhoamiActor = async (identity: Identity) => {
   const idlFactory = () => {
     return IDL.Service({
       whoami: IDL.Func([], [IDL.Principal], ['query']),
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     }) as unknown as any;
   };
   vi.useFakeTimers();
@@ -143,6 +142,7 @@ describe('call forwarding', () => {
   }, 15_000);
 });
 
+
 test('it should allow you to set an incorrect root key', async () => {
   const agent = HttpAgent.createSync({
     rootKey: new Uint8Array(31),
@@ -159,79 +159,3 @@ test('it should allow you to set an incorrect root key', async () => {
 
   expect(actor.whoami).rejects.toThrowError(`Invalid certificate:`);
 });
-
-test('it should throw an error when the clock is out of sync during a query', async () => {
-  const canisterId = 'ivcos-eqaaa-aaaab-qablq-cai';
-  const idlFactory = () => {
-    return IDL.Service({
-      whoami: IDL.Func([], [IDL.Principal], ['query']),
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    }) as unknown as any;
-  };
-  vi.useRealTimers();
-
-  // set date to long ago
-  vi.spyOn(Date, 'now').mockImplementation(() => {
-    return new Date('2021-01-01T00:00:00Z').getTime();
-  });
-  // vi.setSystemTime(new Date('2021-01-01T00:00:00Z'));
-
-  const agent = await HttpAgent.create({ host: 'https://icp-api.io', fetch: globalThis.fetch });
-
-  const actor = Actor.createActor(idlFactory, {
-    agent,
-    canisterId,
-  });
-  try {
-    // should throw an error
-    await actor.whoami();
-  } catch (err) {
-    // handle the replica time error
-    if (err.name === 'ReplicaTimeError') {
-      const error = err as ReplicaTimeError;
-      // use the replica time to sync the agent
-      error.agent.replicaTime = error.replicaTime;
-    }
-  }
-  // retry the call
-  const result = await actor.whoami();
-  expect(Principal.from(result)).toBeInstanceOf(Principal);
-});
-
-test('it should throw an error when the clock is out of sync during an update', async () => {
-  const canisterId = 'ivcos-eqaaa-aaaab-qablq-cai';
-  const idlFactory = () => {
-    return IDL.Service({
-      whoami: IDL.Func([], [IDL.Principal], []),
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    }) as unknown as any;
-  };
-  vi.useRealTimers();
-
-  // set date to long ago
-  vi.spyOn(Date, 'now').mockImplementation(() => {
-    return new Date('2021-01-01T00:00:00Z').getTime();
-  });
-  // vi.setSystemTime(new Date('2021-01-01T00:00:00Z'));
-
-  const agent = await HttpAgent.create({ host: 'https://icp-api.io', fetch: globalThis.fetch });
-
-  const actor = Actor.createActor(idlFactory, {
-    agent,
-    canisterId,
-  });
-  try {
-    // should throw an error
-    await actor.whoami();
-  } catch (err) {
-    // handle the replica time error
-    if (err.name === 'ReplicaTimeError') {
-      const error = err as ReplicaTimeError;
-      // use the replica time to sync the agent
-      error.agent.replicaTime = error.replicaTime;
-      // retry the call
-      const result = await actor.whoami();
-      expect(Principal.from(result)).toBeInstanceOf(Principal);
-    }
-  }
-});

packages/agent/src/actor.ts

@@ -2,7 +2,6 @@ import { Buffer } from 'buffer/';
 import {
   Agent,
   getDefaultAgent,
-  HttpAgent,
   HttpDetailsResponse,
   QueryResponseRejected,
   QueryResponseStatus,
@@ -536,19 +535,13 @@ function _createActorMethod(
       });
       let reply: ArrayBuffer | undefined;
       let certificate: Certificate | undefined;
-      const certTime = (agent as HttpAgent).replicaTime
-        ? (agent as HttpAgent).replicaTime
-        : undefined;
-
-      certTime;
-
       if (response.body && response.body.certificate) {
         const cert = response.body.certificate;
         certificate = await Certificate.create({
           certificate: bufFromBufLike(cert),
           rootKey: agent.rootKey,
           canisterId: Principal.from(canisterId),
-          certTime,
+          blsVerify,
         });
         const path = [new TextEncoder().encode('request_status'), requestId];
         const status = new TextDecoder().decode(

packages/agent/src/agent/api.ts

@@ -119,7 +119,6 @@ export interface CallOptions {
 
 export interface ReadStateResponse {
   certificate: ArrayBuffer;
-  replicaTime?: Date;
 }
 
 export interface SubmitResponse {

packages/agent/src/agent/http/errors.ts

@@ -1,27 +1,10 @@
-import { HttpAgent } from '.';
 import { AgentError } from '../../errors';
 import { HttpDetailsResponse } from '../api';
 
 export class AgentHTTPResponseError extends AgentError {
-  constructor(
-    message: string,
-    public readonly response: HttpDetailsResponse,
-  ) {
+  constructor(message: string, public readonly response: HttpDetailsResponse) {
     super(message);
     this.name = this.constructor.name;
     Object.setPrototypeOf(this, new.target.prototype);
   }
 }
-
-export class ReplicaTimeError extends AgentError {
-  public readonly replicaTime: Date;
-  public readonly agent: HttpAgent;
-
-  constructor(message: string, replicaTime: Date, agent: HttpAgent) {
-    super(message);
-    this.name = 'ReplicaTimeError';
-    this.replicaTime = replicaTime;
-    this.agent = agent;
-    Object.setPrototypeOf(this, new.target.prototype);
-  }
-}

packages/agent/src/agent/http/http.test.ts

@@ -16,8 +16,7 @@ import { JSDOM } from 'jsdom';
 import { Actor, AnonymousIdentity, SignIdentity, toHex } from '../..';
 import { Ed25519KeyIdentity } from '@dfinity/identity';
 import { AgentError } from '../../errors';
-import { AgentHTTPResponseError, ReplicaTimeError } from './errors';
-import { IDL } from '@dfinity/candid';
+import { AgentHTTPResponseError } from './errors';
 const { window } = new JSDOM(`<!DOCTYPE html><p>Hello world</p>`);
 window.fetch = global.fetch;
 (global as any).window = window;
@@ -814,4 +813,3 @@ test('it should log errors to console if the option is set', async () => {
   await agent.syncTime();
 });
 
-jest.setTimeout(5000);