Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retry logic catches thrown errors #774

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Conversation

krpeacock
Copy link
Contributor

Description

Currently, the request and retry feature only handles successful fetch requests that contain error responses. If the fetch request fails due to network conditions, the whole process ejects. This change will have the agent retry failed fetches

How Has This Been Tested?

new Unit test

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner September 26, 2023 20:16
@krpeacock
Copy link
Contributor Author

Next step will be adding an exponential backoff strategy to retries

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

size-limit report 📦

Path Size
@dfinity/agent 88.2 KB (+0.05% 🔺)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 5.2 KB (0%)
@dfinity/auth-client 92.63 KB (0%)
@dfinity/assets 90.6 KB (0%)
@dfinity/identity 89.91 KB (0%)
@dfinity/identity-secp256k1 233.46 KB (+0.02% 🔺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants