Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: retry mops sources call in playground e2e tests #3392

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

ericswanson-dfinity
Copy link
Member

Description

The mops sources command in the playground e2e tests fails often. The retry logic in the JS agent misses some classes of failures (basically, if fetch throws). Pending a fix for that, this change retries the mops sources call up to a few times, with simple/naive backoff.

Example test failures:

@ericswanson-dfinity ericswanson-dfinity marked this pull request as draft September 26, 2023 19:31
@ericswanson-dfinity ericswanson-dfinity marked this pull request as ready for review September 26, 2023 19:55
@chenyan-dfinity
Copy link
Contributor

@ZenVoich Is this something you can fix on mops?

@mergify mergify bot merged commit 1bf35a1 into master Sep 26, 2023
168 checks passed
@mergify mergify bot deleted the retry-mops-sources branch September 26, 2023 22:37
@ericswanson-dfinity
Copy link
Member Author

@ZenVoich Is this something you can fix on mops?

See also dfinity/agent-js#774

@ZenVoich
Copy link

I also faced this problem in GitHub Actions in mops CI. I guess that's the IC's anti-DDoS in action.

I fixed this by caching mops packages, so if mops.toml has not changed mops will not re-download packages each time - https://github.com/ZenVoich/mops/blob/main/.github/workflows/ci.yml#L32-L37

I also published ic-mops 0.27.2 with reduced parallel downloading threads from 16 to 4 when mops install is running in GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants