Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manila: path updates required due to snowflake setup #19280

Closed
2 tasks done
Tracked by #19271
jilladams opened this issue Sep 20, 2024 · 18 comments
Closed
2 tasks done
Tracked by #19271

Manila: path updates required due to snowflake setup #19280

jilladams opened this issue Sep 20, 2024 · 18 comments
Assignees
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) ghp-closed VA Manila Special case VAMC that has custom code implementation

Comments

@jilladams
Copy link
Contributor

jilladams commented Sep 20, 2024

Description

There are some Manila pages using default paths that are incorrect due to the special nature of the Manila setup.

System path

Under normal circumstances, a VAMC System path would be:
System = /PLACE-health-care
Facility = /PLACE-health-care/FACILITY-NAME

Manila is weird because the Facility IS the root of the system. So:
System = will not publish, does not get a FE page. How? There's a FE ticket to figure this out. #19272
Facility = /manila-va-clinic

Affected node paths

These hardened pages are using the default system path, which is incorrect for Manila. Path cannot be overridden on these nodes (the Path options do not appear on the right sidebar of the node pages):

Needed:
VAMC System Billing and Insurance - https://prod.cms.va.gov/manila-va-clinic/billing-and-insurance
VAMC System Medical Records Office - https://prod.cms.va.gov/manila-va-clinic-system-node/medical-records-office
VAMC System Operating Status - https://prod.cms.va.gov/manila-va-clinic-system-node/operating-status
VAMC System Register for Care - https://prod.cms.va.gov/manila-va-clinic-system-node/register-for-care

Not needed:
VAMC System Policies Page - https://prod.cms.va.gov/manila-va-clinic-system-node/policies
VAMC System VA Police page - https://prod.cms.va.gov/manila-va-clinic-system-node/va-police

Editor info

Manila editor has verified that 4 of these pages will be required. This ticket is launch blocking.

Prerequisites

  • Manila editor has confirmed that they need / intend to publish these pages

ACs

  • Path for listed Manila pages is updated to use /manila-va-clinic/ as root
@jilladams jilladams added Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status VA Manila Special case VAMC that has custom code implementation labels Sep 20, 2024
@davidmpickett
Copy link
Contributor

davidmpickett commented Sep 30, 2024

Likely controlled by: https://prod.cms.va.gov/admin/config/search/path/patterns

For Lovell there is a bit of Code in the backend module that disables pathauto for Lovell pages. https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/docroot/mod[…]tom/va_gov_lovell/src/EventSubscriber/LovellEventSubscriber.php
Might make sense to have something similar for Manila if we are going to do them all manually

@Agile6MSkinner
Copy link

Need to reach out to the editor to determine if these are needed and thus launch blocking. Helpdesk to reach out.

@jilladams
Copy link
Contributor Author

Asked Helpdesk for an assist here: https://dsva.slack.com/archives/C02730UEZPS/p1727729745619329

@jilladams
Copy link
Contributor Author

@jilladams
Copy link
Contributor Author

Editor verified they do need 4 of the 6 pages. This ticket is launch blocking, I updated ticket body and launch plan in #19271 accordingly.

@jilladams jilladams removed the Needs refining Issue status label Oct 1, 2024
@jilladams
Copy link
Contributor Author

@jilladams to clarify with the Editor re: whether the centralized content will / won't apply, and wehther a VAMC detail page may be a better fit for the "Need" content of these top task pages.

Pulling into sprint, but: let's wait to start it til I have that info.

@omahane
Copy link
Contributor

omahane commented Oct 3, 2024

@davidmpickett
If manila-va-clinic is the root path for all content, that means we will end up with a facility (Manila VA Clinic) that is at https://prod.cms.va.gov/manila-va-clinic/manila-va-clinic and thus is at https://va.gov/manila-va-clinic/manila-va-clinic.

That may be fine, but I wanted to let you know.

I also notice that none of the health services are of the health services content types but are instead Detail pages. Why is that?

@davidmpickett
Copy link
Contributor

@davidmpickett If manila-va-clinic is the root path for all content, that means we will end up with a facility (Manila VA Clinic) that is at https://prod.cms.va.gov/manila-va-clinic/manila-va-clinic and thus is at https://va.gov/manila-va-clinic/manila-va-clinic.

That may be fine, but I wanted to let you know.

I set the URL alias of the clinic to be https://prod.cms.va.gov/manila-va-clinic Are you saying there's something that will override that?

I also notice that none of the health services are of the health services content types but are instead Detail pages. Why is that?

Those aren't health services, they are health service Care Coordinator pages. These are on all VAMCs but are not super obvious because they aren't in the side nav. Example: https://www.va.gov/chicago-health-care/health-services/mental-health-care/

They are typically linked to from the System health service in the last line of the description https://www.va.gov/chicago-health-care/health-services/#item-mental-health-care

@omahane
Copy link
Contributor

omahane commented Oct 16, 2024

@davidmpickett I have updated the paths (at the https://prod.cms.va.gov/admin/config/search/path) for the needed pages.

For the pages we don't need (Policies and Police), should we archive or delete?

@omahane
Copy link
Contributor

omahane commented Oct 16, 2024

I just tried to create a system health service (on Staging) and got this:
https://staging.cms.va.gov/manila-va-system/health-services/addiction-and-substance-use-care-at-manila-va-clinic

I think we want this to be
https://staging.cms.va.gov/manila-va-clinic/health-services/addiction-and-substance-use-care-at-manila-va-clinic

Then, when I created the facility health service, I got this
https://staging.cms.va.gov/manila-va-clinic/addiction-and-substance-use-care

Maybe it's fine, especially as we're not publishing the system page anyway, so there's no need to show these anywhere.

@jilladams
Copy link
Contributor Author

Dave's out til Tuesday next week: let's archive, as the System may find they need these nodes later.

You are correct that we want th health service path to use manila-va-clinic not manila-va-system. If we don't think it's impactful, yay. I'm not certain of the implications -- we're saying the System health service page won't be visible to anyone bc we don't have a standard system page? (We have to make those in order to enable making a Facility Health Service right?)

@omahane
Copy link
Contributor

omahane commented Oct 17, 2024

Right, the system health services are typically listed on the system page in Drupal, but they don't show on the front-end. So I don't think it really matters what their URL is. The facility health services have the correct path, which is more important.

@jilladams
Copy link
Contributor Author

I archived the nodes we don't need. The work here is done. The open question around the System health services paths is worth getting product to acknowledge the situation / decide if we need to programmatically ward against it, which we could roll into #19406 if so. CLosing this, and flagging that convo for scrum next week.

@davidmpickett
Copy link
Contributor

davidmpickett commented Oct 22, 2024

@omahane Am I correct in my understanding that

  1. You performed a manual update to the paths (admin/config/search/path), rather than changing the patterns (admin/config/search/path/patterns)
  2. While patterns can be exported as config and added to CMS repo as a PR, individual URL aliases / paths are actually stored with the node data and therefore environment-dependent?

@jilladams
Copy link
Contributor Author

jilladams commented Oct 24, 2024

@jilladams jilladams reopened this Oct 24, 2024
@jilladams
Copy link
Contributor Author

Oh -- the paths just aren't righ tin that config. Fixing.

https://prod.cms.va.gov/admin/config/search/path?search=manila

@jilladams
Copy link
Contributor Author

Ok. So in prod, we now have no references to /manila-va-system/ other than the system node itself, on the https://prod.cms.va.gov/admin/config/search/path?search=manila page, and I made the same changes in parallel on the Tugboat, to skip the migration process / make sure we can get through content verification today.

I'm gonna leave this in Functional testing til we can finish the verification that everything is working as expected.

@jilladams
Copy link
Contributor Author

Working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) ghp-closed VA Manila Special case VAMC that has custom code implementation
Projects
None yet
Development

No branches or pull requests

4 participants