-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New VAMC System: VA Manila, and launch plan #19271
Comments
Manila section & content in it: https://prod.cms.va.gov/admin/content?title=Manila&type=All&moderation_state=All&owner=1187 |
Questions that may affect Manila:
Runbook edits / danglers to be addressed in #15264
|
I was also confused why we enabled have Menu settings on these content types. However, all other VAMC system menus are enabled. In lieu of strong evidence that it is a problem, I opted for consistency with previous systems. If it ain't broke, don't fix it mentality.
|
Good catch! I wasn't sure if the Programs page should automatically get the correct alias, but wasn't because of other things not being fully configured. But looking at some other Program pages, they do seem to be manually over-riden, so the runbook should relfect that step. |
I think that will be resolved by this ticket: #19199 |
The source of truth for this is the Manila sitemap in sharepoint. Happy to explain why this differs from the general Sitemap of a VAMC system in sharepoint. |
I think by this you mean things like how the Women Veteran Care page has links to the Mental health care and Patient Advocate pages? And those links are still pointing to the Pacific Islands system I copied the pages from? Even if we expect the editor to do it, might be good to add to editor steps in the runbook. At very least, a good thing for the change management |
Yup, it's listed in the overflowticket #19270 |
|
Under normal circumstances, it would be: Manila is weird because the Facility IS the root of the system. So: SO: all paths for all the Manila pages should include /manila-va-clinic/ as the root. |
Next steps:
Link of Manila VA content that the Editor will need. Emailed Justin to clarify how we get things to the Editor. (Via VHA DM or Helpdesk.) |
@Agile6MSkinner @jilladams FYI - I moved all notes here about updates to make/consider to the runbook over to the runbook ticket #15264 |
Content updates are done, to fix path and remove Pacific Island info, where it was sensible to do so. Pages where I cannot modify path as adminBilling/Insu - https://prod.cms.va.gov/node/72610/edit Before those get published, if they do, we need to figure out whether we can modify the path. I suspect the paths are supposed to be autobuilt for these based on section, using system node path, but that's not gonna work for Manila. Stub to track: #19280 (FYI @Agile6MSkinner ) |
We decided #19227 is not launch blocking. |
Today I yolo'ed and Published > Archived the production System node, since that had not yet been done and is a requirement for everything else to work. |
Doing Tugboat content review Takeaways for follow up:Performance page: appears as a not clickable link in the left sidenav, with current IA / menu setup:https://prod.cms.va.gov/manila-va-clinic/performance Per Eli: To fix the issue I noted, a menu item needs to be added for Performance to nest under. This is something about how vets-website builds the menus. There's probably a way to change it, but it's not super easy Register for care 404s
Make an appointment is set up the same way, but works:
Story nodes are using the System pathhttps://web-xwykohumwbnvcp90arpvpzfkcilh2ngo.demo.cms.va.gov/manila-va-clinic/stories/ Not sure if that will have to be fixed per node that's created, or if we can systematically fix to prevent problems in future? |
All of these might need a fix similar to #19280 |
@jilladams This may be specific to your environment. I'm not sure if the work @omahane did in #19280 works on lower environments. On Prod the Register for Care page in Drupal has the correct path https://prod.cms.va.gov/manila-va-clinic/register-for-care Your tugboat still has it with the system URL path. /manila-va-system/register-for-care |
Hm, good catch. I thought I built my Tugboat after Prod content changes had all shipped, so it should have had all the same settings / paths as prod, with the only difference being what was published / not published. But clearly not so. I'm gonna rebuild it in order to make that true, and rebuild the FE, to confirm. |
@jilladams That was my initial thought too, that if you rebuilt Tugboat it would start working, but actually I think that the way @omahane made these updates means they will not port to lower environments. #19280 (comment) |
@jilladams MEA CULPA. It was just a Tugboat issue. I forgot about the lag between deploys and base previews rebuilding etc. etc. @omahane and I just looked at your Tugboat and it's fine now |
TUGBOAT TESTING ITEMSTesting against Sitemap in Sharepoint, testing notes are documented there as well.
Changes I made to the menuReordered menu items to match the sitemap order, including nesting Leadership and Performance under About Us. Changes I made to the sitemap
|
#1 page title is not launch blocking per Michelle. #3 is now working: pages appear correctly in the About Us section with correct crumbs, Title, and path. Letting Justin know that editor is clear to make / publish everything with the exception of Stories / Staff / Events / News Releases. |
Acceptance criteria
Information needed from Product / VHA DM
Create a new menu through config PR [Drupal Engineer]
Create initial VAMC System Drupal entities [CMS helpdesk or Sitewide team]
<VAMC system plain language name>
Create one copy of each of these hardened VAMC content types [CMS helpdesk or Sitewide team]
URLS BELOW HAVE ALL BEEN UPDATED TO USE /manila-va-clinic/ as the root
<VAMC system plain language name>
-- In the sitemap, Dave has called out: we don't know if Manila can use these as-is, , if not all the required fields & Centralized Content don't apply to Manila. They may want to archive these 4 hardened pages, and instead: make a stand-in page from a VAMC Detail Page template. (This is what Lovell tricare does)Parent link = SERVICES AND LOCATIONS- N/A bc a11y is advocating to stop using the fake headings that aren't links in the sidenavParent link = NEWS AND EVENTS- N/A bc a11y is advocating to stop using the fake headings that aren't links in the sidenavParent link = ABOUT VA [REGION NAME]- N/A bc a11y is advocating to stop using the fake headings that aren't links in the sidenavClone (from where?) these semi-hardened VAMC detail pages [CMS helpdesk or Sitewide team]
<VAMC system plain language name>
Find any existing VAMC facilities that belong to this system [CMS helpdesk or Sitewide team]
Menu configuration and clean up [CMS helpdesk or Sitewide team]
User set up [CMS helpdesk]
VAMC editor tasks
Launch plan
VHA DM
Engineering team
Do we need?
LAUNCH
The text was updated successfully, but these errors were encountered: