Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manila top task pages: 404 from clinic main page #19652

Closed
jilladams opened this issue Oct 30, 2024 · 5 comments
Closed

Manila top task pages: 404 from clinic main page #19652

jilladams opened this issue Oct 30, 2024 · 5 comments
Assignees
Labels
Content model [CMS feature] The bones of the CMS Drupal engineering CMS team practice area Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide VA Manila Special case VAMC that has custom code implementation VAMC CMS managed product owned by Facilities team

Comments

@jilladams
Copy link
Contributor

jilladams commented Oct 30, 2024

Description

Top task links on the Manila clinic page 404.

The main page expects these URLs to be:

Drupal state of affairs 10/30

Make an appointment

this node will need to publish to fix the broken link: https://prod.cms.va.gov/manila-va-clinic/make-an-appointment

Editor can mitigate.

Register for care

Both of these are published, but neither will be live at the expected url (https://va.gov/manila-va-clinic/register-for-care). We will probably need to provide guidance on changing the URL for one of these to end up in the right place.

Pharmacy

Has a published system / facility service, but the VAMC detail page is in draft. If the Editor wanted to publish the detail page, that would solve. Otherwise: we'll need to address similarly to register for care.

Acceptance criteria

  • [ ]
@jilladams jilladams added Needs refining Issue status sitewide VAMC CMS managed product owned by Facilities team Drupal engineering CMS team practice area Content model [CMS feature] The bones of the CMS Facilities Facilities products (VAMC, Vet Center, etc) Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding VA Manila Special case VAMC that has custom code implementation labels Oct 30, 2024
@jilladams
Copy link
Contributor Author

jilladams commented Oct 30, 2024

@omahane @davidmpickett during testing of #19280 and verifying content, I updated the paths for Register for Care in the Paths interface in prod and on Tugboat, to correct the /manila-va-system/paths to use /manila-va-clinic/. But many of those manila-va-system paths are now appearing again:

https://prod.cms.va.gov/admin/config/search/path?search=manila-va-system

Specifically, /manila-va-system/register-for-care and /manila-va-system/operating-status. I can update them again in prod again now, but: any flags or concerns before I do that?

@jilladams
Copy link
Contributor Author

Other issues: https://dsva.slack.com/archives/C0FQSS30V/p1730321278307029?thread_ts=1730314164.682529&cid=C0FQSS30V

  • On a node, there are menu settings. Even if inactive, they can be set incorrectly (in this case, nesting under the System menu item, not the clinic-as-system item). e.g. on https://prod.cms.va.gov/node/72716/edit, in screenshot
  • In the menu, the menu was constructed correctly.
  • HOWEVER: every time the node saves, the incorrect menu settings are saved and overwrite the menu order established in the menu itself. (The node save rearranges the menu.)

That means this will continue to be an issue as these nodes get edited / resaved.

Questions:

@jilladams
Copy link
Contributor Author

I went ahead and edited the Register for Care path setting here: https://prod.cms.va.gov/admin/config/search/path/edit/112910?destination=/admin/config/search/path%3Fsearch%3Dregister-for-care%26page%3D4. and updated it to `manila-va-clinic/register for care. If that reverts, there are ghosts in the machine.

Image

Noting: this node (https://prod.cms.va.gov/node/72706) has the menu item set correctly, from the node view.

Image

@jilladams
Copy link
Contributor Author

Same for:

Medical records, which had reset to -system: https://prod.cms.va.gov/admin/config/search/path/edit/112900?destination=/admin/config/search/path%3Fsearch%3Dmanila%26page%3D1

URL alias is now set to: /manila-va-clinic/medical-records-office

Operating status: https://prod.cms.va.gov/admin/config/search/path/edit/112903?destination=/admin/config/search/path%3Fsearch%3Dmanila%26page%3D1
Now: /manila-va-clinic/operating-status

Billing & Insurance: https://prod.cms.va.gov/admin/config/search/path/edit/112675?destination=/admin/config/search/path%3Fsearch%3Dmanila%26page%3D1
Now: /manila-va-clinic/billing-and-insurance

@jilladams
Copy link
Contributor Author

Today, the paths are fixed, nodes are published, and these 3 links are working in prod. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content model [CMS feature] The bones of the CMS Drupal engineering CMS team practice area Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide VA Manila Special case VAMC that has custom code implementation VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

2 participants