Merge pull request #229 from erfanium/e4

bug: fix `countDocuments` error when called without filter
denodrivers · Aug 14, 2021 · 1dc29e1 · 1dc29e1
2 parents 3f32126 + fa5dfa6
commit 1dc29e1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/collection/collection.ts b/src/collection/collection.ts
@@ -94,7 +94,10 @@ export class Collection<T> {
     filter?: Document,
     options?: CountOptions,
   ): Promise<number> {
-    const pipeline: Document[] = [{ $match: filter }];
+    const pipeline: Document[] = [];
+    if (filter) {
+      pipeline.push({ $match: filter });
+    }
 
     if (typeof options?.skip === "number") {
       pipeline.push({ $skip: options.skip });

diff --git a/tests/cases/03_curd.ts b/tests/cases/03_curd.ts
@@ -251,6 +251,9 @@ export default function curdTests() {
   testWithClient("testCountDocuments", async (client) => {
     const db = client.database("test");
     const users = db.collection("mongo_test_users");
+    const countAll = await users.countDocuments();
+    assertEquals(countAll, 4);
+
     const count = await users.countDocuments({ username: "many" });
     assertEquals(count, 2);
   });