chore: use ES6 for...of instead of forEach (#228)

src/cluster.ts

@@ -124,12 +124,12 @@ export class Cluster {
   }
 
   close() {
-    this.#connections.forEach((connection) => {
+    for (const conn of this.#connections) {
       try {
-        Deno.close(connection.rid);
+        Deno.close(conn.rid);
       } catch (error) {
         console.error(`Error closing connection: ${error}`);
       }
-    });
+    }
   }
 }

src/protocol/message.ts

@@ -76,10 +76,10 @@ export function serializeMessage(message: Message): Uint8Array[] {
   view.setInt32(0, message.flags ?? 0, true);
 
   let pos = 4;
-  sections.forEach((section) => {
+  for (const section of sections) {
     buffer.set(section, pos);
     pos += section.byteLength;
-  });
+  }
 
   const header = serializeHeader({
     messageLength: 16 + buffer.byteLength,

src/protocol/protocol.ts

@@ -57,13 +57,13 @@ export class WireProtocol {
 
     let documents: T[] = [];
 
-    message?.sections.forEach((section) => {
+    for (const section of message?.sections!) {
       if ("document" in section) {
         documents.push(section.document as T);
       } else {
         documents = documents.concat(section.documents as T[]);
       }
-    });
+    }
 
     return documents;
   }

src/utils/srv.ts

@@ -95,11 +95,11 @@ export class Srv {
       valid: {},
       illegal: [],
     };
-    optionsUri.split("&").forEach((option: string) => {
+    for (const option of optionsUri.split("&")) {
       const [key, value] = option.split("=");
       if (isAllowedOption(key) && !!value) options.valid[key] = value;
       else options.illegal.push(option);
-    });
+    }
 
     if (options.illegal.length !== 0) {
       throw new SRVError(

tests/cases/01_auth.ts

@@ -16,7 +16,7 @@ interface PasswordValid {
   digest: string;
 }
 
-const passwordValdis: PasswordValid[] = [
+const passwordValids: PasswordValid[] = [
   {
     username: "user",
     password: "pencil",
@@ -30,15 +30,15 @@ const passwordValdis: PasswordValid[] = [
 ];
 
 export default function authTests() {
-  passwordValdis.forEach(({ username, password, digest }) => {
+  for (const { username, password, digest } of passwordValids) {
     Deno.test({
       name: `passwordDigest:${username}:${password}`,
       fn() {
         const digestRes: string = passwordDigest(username, password);
         assertEquals(digestRes, digest);
       },
     });
-  });
+  }
 
   Deno.test({
     name: "clientFirstMessageBare",