Skip to content

Commit

Permalink
Elasicsearch V2 - added test of the fetch-incident related parameters…
Browse files Browse the repository at this point in the history
… to the test-module (#37843)

* Added a test of fetch incidents to the test module

* Added RN

* Improved rn

* Improved rn file

* Removed the 'test-module' from the RN file

* Keep only fetch param tests in the test module

* Update Packs/Elasticsearch/Integrations/Elasticsearch_v2/Elasticsearch_v2.yml

Co-authored-by: yuvalbenshalom <[email protected]>

* Update Packs/Elasticsearch/Integrations/Elasticsearch_v2/Elasticsearch_v2.yml

Co-authored-by: yuvalbenshalom <[email protected]>

* Update Packs/Elasticsearch/Integrations/Elasticsearch_v2/Elasticsearch_v2_description.md

Co-authored-by: yuvalbenshalom <[email protected]>

* wordings fix

* Update Packs/Elasticsearch/Integrations/Elasticsearch_v2/Elasticsearch_v2.yml

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/Elasticsearch/Integrations/Elasticsearch_v2/Elasticsearch_v2.yml

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/Elasticsearch/Integrations/Elasticsearch_v2/Elasticsearch_v2_description.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/Elasticsearch/Integrations/Elasticsearch_v2/Elasticsearch_v2.yml

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/Elasticsearch/ReleaseNotes/1_3_25.md

Co-authored-by: ShirleyDenkberg <[email protected]>

---------

Co-authored-by: yuvalbenshalom <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
  • Loading branch information
3 people authored Dec 29, 2024
1 parent 912c0ee commit 96d419b
Show file tree
Hide file tree
Showing 5 changed files with 34 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,18 @@ def verify_es_server_version(res):


def test_func(proxies):
"""
Tests API connectivity to the Elasticsearch server.
Tests the existence of all necessary fields for fetch.
Due to load considerations, the test module doesn't check the validity of the fetch-incident - to test that the fetch works
as excepted the user should run the es-integration-health-check command.
"""
test_connectivity_auth(proxies)
if demisto.params().get('isFetch'):
# check the existence of all necessary fields for fetch
fetch_params_check()
demisto.results('ok')


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,28 @@ configuration:
- display: Query String
name: fetch_query
type: 0
additionalinfo: The query will be used when fetching incidents. Index time field will be used as a filter in the query.
additionalinfo: |-
The query will be used when fetching incidents. Index time field will be used as a filter in the query.
The integration test button doesn't fully test the fetch incidents validity. To verify that the instance is set up correctly for fetching incidents, run the '!es-integration-health-check' command.
section: Collect
advanced: true
required: false
- display: Index time field (for sorting sort and limiting data)
name: fetch_time_field
type: 0
section: Collect
advanced: true
required: false
additionalinfo: The time field on which sorting and limiting are performed. If using a nested field, separate field names using dot notation.
additionalinfo: |-
The time field on which sorting and limiting are performed. If using a nested field, separate field names using dot notation.
The integration test button doesn't fully test the fetch incidents validity. To verify that the instance is set up correctly for fetching incidents, run the '!es-integration-health-check' command.
- display: Raw Query
name: raw_query
type: 12
additionalinfo: Will override the 'Query String' Lucene syntax string. Results will not be filtered.
additionalinfo: |-
Will override the 'Query String' Lucene syntax string. Results will not be filtered.
The integration test button doesn't fully test the fetch incidents validity. To verify that the instance is set up correctly for fetching incidents, run the '!es-integration-health-check' command.
section: Collect
advanced: true
required: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,7 @@ The types of time-fields supported are:
- **Timestamp-Second** - A number referring to seconds since epoch (midnight, 1 January 1970). For example: '1572164838'.
- **Timestamp-Milliseconds** - A number referring to milliseconds since epoch (midnight, 1 January 1970). For example: '1572164838123'.

Note: Not all fields can be sorted in Elasticsearch. The fields are used to sort the results table. The supported result types are boolean, numeric, date, and keyword fields.
Notes:
- Not all fields can be sorted in Elasticsearch. The fields are used to sort the results table.
The supported result types are boolean, numeric, date, and keyword fields.
- The integration test button doesn't fully test the fetch incidents validity. To verify that the instance is set up correctly for fetching incidents, run the ***!es-integration-health-check*** command.
6 changes: 6 additions & 0 deletions Packs/Elasticsearch/ReleaseNotes/1_3_25.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### Elasticsearch v2

Fixed an issue where the fetch-incidents-related parameters were not tested by clicking the integration test button.
2 changes: 1 addition & 1 deletion Packs/Elasticsearch/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Elasticsearch",
"description": "Search for and analyze data in real time. \n Supports version 6 and later.",
"support": "xsoar",
"currentVersion": "1.3.24",
"currentVersion": "1.3.25",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down

0 comments on commit 96d419b

Please sign in to comment.