Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ts): add typing to adjudicators used in validation and mutation processing #1402

Open
wants to merge 56 commits into
base: main
Choose a base branch
from

Merge branch 'main' into 1397-type-adjudicators

54d04d6
Select commit
Loading
Failed to load commit list.
Open

chore(ts): add typing to adjudicators used in validation and mutation processing #1402

Merge branch 'main' into 1397-type-adjudicators
54d04d6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 2, 2024 in 0s

79.21% (+0.04%) compared to 4e79c36

View this Pull Request on Codecov

79.21% (+0.04%) compared to 4e79c36

Details

Codecov Report

Attention: Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.21%. Comparing base (4e79c36) to head (54d04d6).

Files with missing lines Patch % Lines
src/lib/filter/adjudicators.ts 88.57% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
+ Coverage   79.17%   79.21%   +0.04%     
==========================================
  Files          39       40       +1     
  Lines        1719     1742      +23     
  Branches      388      420      +32     
==========================================
+ Hits         1361     1380      +19     
- Misses        356      360       +4     
  Partials        2        2              
Files with missing lines Coverage Δ
src/lib/filter/adjudicators/defaultTestObjects.ts 100.00% <100.00%> (ø)
src/lib/filter/filter.ts 97.77% <100.00%> (+0.27%) ⬆️
src/lib/helpers.ts 97.93% <100.00%> (-0.03%) ⬇️
src/lib/filter/adjudicators.ts 97.03% <88.57%> (-2.97%) ⬇️