Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ts): add typing to adjudicators used in validation and mutation processing #1402

Open
wants to merge 55 commits into
base: main
Choose a base branch
from

Conversation

samayer12
Copy link
Collaborator

@samayer12 samayer12 commented Nov 7, 2024

Description

The adjudicators are untyped, which caused complications when merging PR #1333. We should use TypeScript to enforce typing so that any refactors to filtering are based upon a solid foundation that does not require intermediate kludges with the typing system.

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Relates to #1248, #1406, #1407, #1408, #1409, #1397

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (2da08c2) to head (257c4b8).

Files with missing lines Patch % Lines
src/lib/filter/adjudicators.ts 88.57% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
+ Coverage   78.56%   78.62%   +0.05%     
==========================================
  Files          38       39       +1     
  Lines        1717     1740      +23     
  Branches      410      393      -17     
==========================================
+ Hits         1349     1368      +19     
- Misses        339      370      +31     
+ Partials       29        2      -27     
Files with missing lines Coverage Δ
src/lib/filter/adjudicators/defaultTestObjects.ts 100.00% <100.00%> (ø)
src/lib/filter/filter.ts 97.77% <100.00%> (+0.27%) ⬆️
src/lib/helpers.ts 97.93% <100.00%> (-0.03%) ⬇️
src/lib/filter/adjudicators.ts 97.03% <88.57%> (-2.97%) ⬇️

... and 7 files with indirect coverage changes

---- 🚨 Try these New Features:

github-merge-queue bot pushed a commit that referenced this pull request Nov 22, 2024
## Description

This PR moves a helper function to a dedicated file (filename open to
discussion). This change was planned as part of #1402, we can bring it
in here to reduce the amount of changes we consider at any given time.

## Related Issue

Relates to #1397

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed
@samayer12 samayer12 marked this pull request as ready for review November 22, 2024 20:10
@samayer12 samayer12 requested a review from a team as a code owner November 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants