-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ts): add typing to adjudicators used in validation and mutation processing #1402
Open
samayer12
wants to merge
55
commits into
main
Choose a base branch
from
1397-type-adjudicators
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,202
−966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
samayer12
force-pushed
the
1397-type-adjudicators
branch
from
November 8, 2024 19:31
029545e
to
627f291
Compare
samayer12
force-pushed
the
1397-type-adjudicators
branch
from
November 18, 2024 19:24
627f291
to
a169536
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
+ Coverage 78.56% 78.62% +0.05%
==========================================
Files 38 39 +1
Lines 1717 1740 +23
Branches 410 393 -17
==========================================
+ Hits 1349 1368 +19
- Misses 339 370 +31
+ Partials 29 2 -27
|
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
## Description This PR moves a helper function to a dedicated file (filename open to discussion). This change was planned as part of #1402, we can bring it in here to reduce the amount of changes we consider at any given time. ## Related Issue Relates to #1397 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The adjudicators are untyped, which caused complications when merging PR #1333. We should use TypeScript to enforce typing so that any refactors to filtering are based upon a solid foundation that does not require intermediate kludges with the typing system.
End to End Test:
(See Pepr Excellent Examples)
Related Issue
Relates to #1248, #1406, #1407, #1408, #1409, #1397
Type of change
Checklist before merging