Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tf): apply exclude types to se_atten_v2 switch #3651

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Apr 7, 2024

I construct a test case in which all old implementations fail.

@njzjz njzjz added this to the v2.2.11 milestone Apr 7, 2024
@njzjz njzjz requested review from iProzd and wanghan-iapcm April 7, 2024 06:03
@github-actions github-actions bot added the Python label Apr 7, 2024
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (87d293a) to head (a4810e8).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3651   +/-   ##
=======================================
  Coverage   81.80%   81.80%           
=======================================
  Files         503      503           
  Lines       46456    46457    +1     
  Branches     2952     2952           
=======================================
+ Hits        38004    38005    +1     
  Misses       7559     7559           
  Partials      893      893           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jinzhe Zeng <[email protected]>
@iProzd iProzd added this pull request to the merge queue Apr 8, 2024
Merged via the queue into deepmodeling:devel with commit 09fd3bb Apr 8, 2024
49 checks passed
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Apr 18, 2024
Fix type issue in previous PR deepmodeling#3651.

Signed-off-by: Jinzhe Zeng <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Apr 18, 2024
Fix type issue in previous PR #3651.

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Jul 2, 2024
I construct a test case in which all old implementations fail.

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
(cherry picked from commit 09fd3bb)
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Jul 2, 2024
Fix type issue in previous PR deepmodeling#3651.

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit cac8715)
@njzjz njzjz mentioned this pull request Jul 2, 2024
njzjz added a commit that referenced this pull request Jul 3, 2024
I construct a test case in which all old implementations fail.

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
(cherry picked from commit 09fd3bb)
njzjz added a commit that referenced this pull request Jul 3, 2024
Fix type issue in previous PR #3651.

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit cac8715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants