fix: remove model_def_script from AtomicModel #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After deepmodeling#3438, `model_def_script` is no more saved in AtomicModel. Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3449 +/- ##
=======================================
Coverage 77.29% 77.29%
=======================================
Files 427 427
Lines 36913 36910 -3
Branches 1621 1621
=======================================
- Hits 28531 28529 -2
+ Misses 7514 7513 -1
Partials 868 868 ☔ View full report in Codecov by Sentry. |
njzjz
force-pushed
the
fix-model-def-script
branch
from
752a06d to
72fbcfd
Compare
wanghan-iapcm
approved these changes
Mar 12, 2024
Signed-off-by: Jinzhe Zeng <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
This PR is based on #3449, as the test needs #3449 to pass. Add a consistent `frozen` model in pt. Both TF and PT now support using models in any format. --------- Signed-off-by: Jinzhe Zeng <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #3438,
model_def_scriptis no more saved in AtomicModel.