Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ZBL null test #3447

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Conversation

anyangml
Copy link
Collaborator

This PR should address #3392 .

@anyangml anyangml requested a review from wanghan-iapcm March 11, 2024 10:15
@anyangml anyangml added the bug label Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.51%. Comparing base (804848a) to head (9b918c5).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3447      +/-   ##
==========================================
+ Coverage   77.39%   77.51%   +0.11%     
==========================================
  Files         427      394      -33     
  Lines       36755    31956    -4799     
  Branches     1621      909     -712     
==========================================
- Hits        28446    24770    -3676     
+ Misses       7441     6658     -783     
+ Partials      868      528     -340     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm enabled auto-merge March 11, 2024 14:38
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Mar 11, 2024
Merged via the queue into deepmodeling:devel with commit 619fd1c Mar 11, 2024
48 checks passed
@njzjz njzjz linked an issue Mar 11, 2024 that may be closed by this pull request
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ZBL and hybrid models do not pass the null UT
2 participants