Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ZBL and hybrid models do not pass the null UT #3392

Closed
wanghan-iapcm opened this issue Mar 2, 2024 · 0 comments · Fixed by #3447 or #3396
Closed

[BUG] ZBL and hybrid models do not pass the null UT #3392

wanghan-iapcm opened this issue Mar 2, 2024 · 0 comments · Fixed by #3447 or #3396
Assignees
@njzjz @anyangml
Labels
bug
Milestone
v3.0.0

Comments

@wanghan-iapcm
Copy link
Collaborator

Bug summary

ZBL and hybrid models does not pass the testing case of number of neighboring atoms == 0.

DeePMD-kit Version

devel

TensorFlow Version

2.14.0

How did you download the software?

Others (write below)

Input Files, Running Commands, Error Log, etc.

testing case provided by #3391

Steps to Reproduce

comment out the line

deepmd-kit/source/tests/pt/model/test_null_input.py

Line 122 in 89dff77

@unittest.skip("hybrid not supported at the moment")
to reproduce the hybrid issue

comment out the line

deepmd-kit/source/tests/pt/model/test_null_input.py

Line 140 in 89dff77

@unittest.skip("FAILED at the moment")
to reproduce the zbl issue

Further Information, Files, and Links

No response
@njzjz njzjz added this to the v3.0.0 milestone Mar 9, 2024
@anyangml anyangml mentioned this issue Mar 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 11, 2024
@anyangml @pre-commit-ci @wanghan-iapcm
Fix: ZBL null test (#3447)
619fd1c 
This PR should address #3392 .

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Han Wang <[email protected]>
This was linked to pull requests Mar 11, 2024
Fix: ZBL null test #3447
Merged
do not return g2, h2, sw in hybrid descriptors #3396
Merged
@njzjz njzjz closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njzjz njzjz

@anyangml anyangml

Labels
bug
Projects
Multiple backend support for DeePMD-kit
Archived in project
Milestone
v3.0.0
3 participants
@njzjz @wanghan-iapcm @anyangml