Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paddle Backend][Fix] Fix wrong custom operator installation filename #3127

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

HydrogenSulfate
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate commented Jan 10, 2024

  1. Fix wrong custom operator installation filename
  2. Fix missing file deepmd/entrypoints/gui.py
  3. Annotated @cast_precision and keep brackets [] util problems fixed @SigureMo

@njzjz Besides, can you please help to rename paddle branch to paddle_1 or other backup name, and then change paddle2 to paddle branch? Because user may get confused aboout the difference between paddle2 and paddle`. Thanks a lot.

@HydrogenSulfate HydrogenSulfate changed the title [Fix] Fix wrong custom operator installation filename [Paddle Backend][Fix] Fix wrong custom operator installation filename Jan 10, 2024
@njzjz njzjz merged commit f132a39 into deepmodeling:paddle2 Jan 10, 2024
6 of 29 checks passed
@njzjz
Copy link
Member

njzjz commented Jan 10, 2024

@njzjz Besides, can you please help to rename paddle branch to paddle_1 or other backup name, and then change paddle2 to paddle branch? Because user may get confused aboout the difference between paddle2 and paddle`. Thanks a lot.

I am unsure if it will break any external URL linking to the paddle branch. However, you can consider adding a note to the top of README.md in the paddle branch.

@HydrogenSulfate HydrogenSulfate deleted the fix_doc branch January 11, 2024 03:03
@HydrogenSulfate
Copy link
Contributor Author

@njzjz Besides, can you please help to rename paddle branch to paddle_1 or other backup name, and then change paddle2 to paddle branch? Because user may get confused aboout the difference between paddle2 and paddle`. Thanks a lot.

I am unsure if it will break any external URL linking to the paddle branch. However, you can consider adding a note to the top of README.md in the paddle branch.

You are right, I will search for it and add a note to the old paddle branch, thanks.

njzjz pushed a commit that referenced this pull request Jan 12, 2024
Update caution notes and re-formatting README.md in old paddle branch as
@njzjz advised at #3127 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants