Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paddle Backend] Deprecate old paddle branch #3130

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

HydrogenSulfate
Copy link
Contributor

Update caution notes and re-formatting README.md in old paddle branch as @njzjz advised at #3127 .

README.md Outdated
>
> **The current branch is no longer maintained due to the outdated Paddle version it adapts to and the significant differences from the DeePMD-kit main branch.**
>
> **The new paddle backend branch is [DeePMD-kit(paddle branch)](https://github.com/deepmodeling/deepmd-kit/tree/paddle)**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the branch be paddle2?

Copy link
Contributor Author

@HydrogenSulfate HydrogenSulfate Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the branch be paddle2?

I guess paddle2 is not suitable name in the future, and code in old paddle should be removed or moved to other branch name as is not runnable, so can we add extra deprecation note, such as: "As described above, the current paddle branch will be replaced with the content in paddle2 branch after 2024.x.y".
And when arrived 2024.x.y, we replace code in paddle branch with code in paddle2 then delete paddle2 branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not necessary if we want to rename the branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not necessary if we want to rename the branch

URL has been updated

Copy link
Contributor Author

@HydrogenSulfate HydrogenSulfate Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not necessary if we want to rename the branch

paddle branch will not be maintain any more and the code in paddle branch is too old to run. so I guess it is necessary to remove paddle branch after certain day and move paddle2's code into paddle branch, or any user use paddle branch will not be able to run any code, that's why there is no need to preserve this branch.

Copy link
Member

@njzjz njzjz Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rename it tomorrow. I prefer keeping the old branch for the recording purposes. Even if no one uses it, people can know the history of development through the old branch.

By the way, we will focus on supporting multiple backends in the next five weeks. After we refactor several codes, it's more easier to support Paddle in the main development branch.

Copy link
Contributor Author

@HydrogenSulfate HydrogenSulfate Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rename it tomorrow. I prefer keeping the old branch for the recording purposes. Even if no one uses it, people can know the history of development through the old branch.

By the way, we will focus on supporting multiple backends in the next five weeks. After we refactor several codes, it's more easier to support Paddle in the main development branch.

  1. I agree with you much that we need to record old code and history of it even if no one use(so there indeed unnecessary to delete old code), but I guess it is important to move the old code to some "bakcup" branch but not be kept in offcial branch(paddle branch), since an official branch is important or will cause recognition error, and we always prefer showing newest runnable code for those who use DeePMD-kit with paddle backend in official branch.

  2. It is very glad to hear that a multi-backend project is released and you are working for it, willing to help to build together after multi-bakend is finished.

Thanks for your reply.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed paddle to paddle-backup and paddle2 to paddle.

@njzjz
Copy link
Member

njzjz commented Jan 11, 2024

@CodiumAI-Agent /review --pr_reviewer.inline_code_comments=true

@CodiumAI-Agent
Copy link
Contributor

CodiumAI-Agent commented Jan 11, 2024

PR Analysis

(review updated until commit 608b868)

  • 🎯 Main theme: Deprecating old paddle branch and updating README
  • 📝 PR summary: This PR updates the README file in the old paddle branch of the DeePMD-kit project, adding a caution note to indicate that the branch is no longer maintained due to its outdated Paddle version and significant differences from the main branch. The PR also includes some reformatting and minor changes to the README content.
  • 📌 Type of PR: Documentation
  • 🧪 Relevant tests added: False
  • ⏱️ Estimated effort to review [1-5]: 1, because the PR only involves changes to the README file and does not affect any functional code.
  • 🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The changes made in this PR are clear and well-explained. The caution note is a good addition to inform users about the status of the branch. The reformatting and minor changes to the README content also improve its readability.


✨ Usage guide:

Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...
Utilizing extra instructions

The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.

Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.

Examples for extra instructions:

[pr_reviewer] # /review #
extra_instructions="""
In the code feedback section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

How to enable\disable automation
  • When you first install PR-Agent app, the default mode for the review tool is:
pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

About the 'Code feedback' section

The review tool provides several type of feedbacks, one of them is code suggestions.
If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results.
Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

Auto-labels

The review tool can auto-generate two specific types of labels for a PR:

  • a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
  • a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)
Extra sub-tools

The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_review, enable_review_labels_effort, and more.

More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

  • /review: Request a review of your Pull Request.
  • /describe: Update the PR title and description based on the contents of the PR.
  • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
  • /ask <QUESTION>: Ask a question about the PR.
  • /update_changelog: Update the changelog based on the PR's contents.
  • /add_docs 💎: Generate docstring for new components introduced in the PR.
  • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
  • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

@CodiumAI-Agent
Copy link
Contributor

Persistent review updated to latest commit 608b868

@njzjz njzjz merged commit 6ec609c into deepmodeling:paddle Jan 12, 2024
2 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants