-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Paddle Backend] Deprecate old paddle branch #3130
[Paddle Backend] Deprecate old paddle branch #3130
Conversation
README.md
Outdated
> | ||
> **The current branch is no longer maintained due to the outdated Paddle version it adapts to and the significant differences from the DeePMD-kit main branch.** | ||
> | ||
> **The new paddle backend branch is [DeePMD-kit(paddle branch)](https://github.com/deepmodeling/deepmd-kit/tree/paddle)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the branch be paddle2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the branch be
paddle2
?
I guess paddle2
is not suitable name in the future, and code in old paddle should be removed or moved to other branch name as is not runnable, so can we add extra deprecation note, such as: "As described above, the current paddle
branch will be replaced with the content in paddle2
branch after 2024.x.y".
And when arrived 2024.x.y, we replace code in paddle
branch with code in paddle2
then delete paddle2
branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is not necessary if we want to rename the branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is not necessary if we want to rename the branch
URL has been updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is not necessary if we want to rename the branch
paddle branch will not be maintain any more and the code in paddle branch is too old to run. so I guess it is necessary to remove paddle branch after certain day and move paddle2's code into paddle branch, or any user use paddle branch will not be able to run any code, that's why there is no need to preserve this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rename it tomorrow. I prefer keeping the old branch for the recording purposes. Even if no one uses it, people can know the history of development through the old branch.
By the way, we will focus on supporting multiple backends in the next five weeks. After we refactor several codes, it's more easier to support Paddle in the main development branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rename it tomorrow. I prefer keeping the old branch for the recording purposes. Even if no one uses it, people can know the history of development through the old branch.
By the way, we will focus on supporting multiple backends in the next five weeks. After we refactor several codes, it's more easier to support Paddle in the main development branch.
-
I agree with you much that we need to record old code and history of it even if no one use(so there indeed unnecessary to delete old code), but I guess it is important to move the old code to some "bakcup" branch but not be kept in offcial branch(
paddle
branch), since an official branch is important or will cause recognition error, and we always prefer showing newest runnable code for those who use DeePMD-kit with paddle backend in official branch. -
It is very glad to hear that a multi-backend project is released and you are working for it, willing to help to build together after multi-bakend is finished.
Thanks for your reply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed paddle
to paddle-backup
and paddle2
to paddle
.
@CodiumAI-Agent /review --pr_reviewer.inline_code_comments=true |
PR Analysis(review updated until commit 608b868)
PR Feedback💡 General suggestions: The changes made in this PR are clear and well-explained. The caution note is a good addition to inform users about the status of the branch. The reformatting and minor changes to the README content also improve its readability. ✨ Usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
Persistent review updated to latest commit 608b868 |
Update caution notes and re-formatting README.md in old paddle branch as @njzjz advised at #3127 .