trying to debug the cd4t multi commit before merging it in the baseline

.env.example

@@ -0,0 +1,22 @@
+# This is an example .env file with default passwords and private keys.
+# Do not use this in production or with any public-facing ports!
+BACKEND_HOST=backend                                    # name of the 'backend' container
+BACKEND_PORT=5000                                       # port of the 'backend' container
+COMPOSE_FILE=./docker-compose/docker-compose.yml        # Docker Compose configuration file to use
+DATABASE_HOST=db                                        # name of the PostgreSQL container
+DATABASE_PASSWORD=Ohw0phoa                              # choose any PostgreSQL password
+DATABASE_PORT=5432                                      # port of the PostgreSQL container
+DATABASE_USERNAME=dvoting
+DB_PATH=dvoting                                         # LMDB database path
+DELA_PROXY_URL=http://172.19.44.254:8080                # IP and port of one of the DELA containers
+FRONT_END_URL=http://127.0.0.1:3000                     # the automated frontend tests expect this value do not change it
+NODEPORT=2000                                           # DELA node port
+# For public-facing services and production, this key needs to be changed!
+PRIVATE_KEY=6aadf480d068ac896330b726802abd0da2a5f3824f791fe8dbd4cd555e80b809
+PROXYPORT=8080                                          # DELA proxy port
+PUBLIC_KEY=3e5fcaed4c5d79a8eccceeb087ee0a13b8f91d917ed62017a9cd28e13b228389
+REACT_APP_DEV_LOGIN=true                                # debugging admin login /!\ disable in production /!\
+REACT_APP_RANDOMIZE_VOTE_ID=true                        # randomize voter ID for debugging /!\ disable in production /!\
+REACT_APP_SCIPER_ADMIN=123456                           # debugging admin ID /!\ disable in production /!\
+REACT_APP_BLOCKLIST=                                    # comma-separad form IDs to hide from non-admin users
+SESSION_SECRET=kaibaaF9                                 # choose any secret

.github/pull_request_template.md

@@ -0,0 +1,10 @@
+Thank you for opening a pull request with this project, please also:
+
+* [ ] add a brief description of your changes here
+* [ ] assign the PR to yourself, or to the person(s) working on it
+* [ ] start in `draft` mode and `in progress` pipeline in the project (if applicable)
+* [ ] if applicable, add this PR to its related issue by one of the special keywords [Closing keywords](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue)
+* once it's ready 
+  * [ ] put it in the `Review` or `Ready4Merge` pipeline in the project (if applicable) 
+  * [ ] remove `draft`
+  * [ ] assign a reviewer

.github/workflows/build-docker.yml

@@ -0,0 +1,67 @@
+name: Build docker
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
+
+jobs:
+  build-docker:
+    name: Build D-Voting Docker images
+    runs-on: ubuntu-22.04
+    env:
+      DockerTag: latest
+      push: ${{ (github.ref == 'refs/heads/main') && 'true' || 'false' }}
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Set env
+        run: |
+          git describe --tags
+          echo "REACT_APP_VERSION=$(git describe --tags --abbrev=0)" >> $GITHUB_ENV        
+          echo "REACT_APP_BUILD=$(git describe --tags)" >> $GITHUB_ENV        
+          echo "REACT_APP_BUILD_TIME=$(date)" >> $GITHUB_ENV
+      - name: Set up Docker Buildx
+        id: buildx
+        uses: docker/setup-buildx-action@v3
+      - name: Login to GHCR
+        if: ${{ env.push == 'true' }}
+        uses: docker/login-action@v3
+        with:
+          registry: ghcr.io
+          username: ${{ github.repository_owner }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Build Frontend
+        uses: docker/build-push-action@v6
+        with:
+          context: .
+          file: Dockerfiles/Dockerfile.frontend
+          platforms: linux/amd64
+          build-args: |
+            REACT_APP_VERSION
+            REACT_APP_BUILD
+            REACT_APP_BUILD_TIME
+          push: ${{ env.push }}
+          tags: ghcr.io/dedis/d-voting-frontend:${{ env.DockerTag }}
+      - name: Build Backend
+        uses: docker/build-push-action@v6
+        with:
+          context: .
+          file: Dockerfiles/Dockerfile.backend
+          platforms: linux/amd64
+          push: ${{ env.push }}
+          tags: ghcr.io/dedis/d-voting-backend:${{ env.DockerTag }}
+      - name: Build D-Voting
+        uses: docker/build-push-action@v6
+        with:
+          context: .
+          file: Dockerfiles/Dockerfile.dela
+          platforms: linux/amd64
+          push: ${{ env.push }}
+          tags: ghcr.io/dedis/d-voting-dela:${{ env.DockerTag }}

.github/workflows/go_dvoting_test.yml

@@ -12,10 +12,10 @@ jobs:
     name: Scenario
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go ^1.17
-        uses: actions/setup-go@v2
+      - name: Use Go 1.23
+        uses: actions/setup-go@v4
         with:
-          go-version: ^1.17
+          go-version: '1.23'
 
       - name: Install crypto util from Dela
         run: |
@@ -24,7 +24,7 @@ jobs:
           go install ./cli/crypto
 
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Create a private key
         run: crypto bls signer new --save private.key

.github/workflows/go_integration_tests.yml

@@ -8,58 +8,63 @@ on:
 
 jobs:
   integration:
-    name: Integration test
+    name: Integration tests
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go ^1.17
-        uses: actions/setup-go@v2
+      - name: Use Go 1.23
+        uses: actions/setup-go@v4
         with:
-          go-version: ^1.17
+          go-version: '1.23'
 
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Run the integration test
         run: go test -timeout 10m -run TestIntegration ./integration/... 
   bad_vote:
     name: Test bad vote
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go ^1.17
-        uses: actions/setup-go@v2
+      - name: Use Go 1.23
+        uses: actions/setup-go@v4
         with:
-          go-version: ^1.17
+          go-version: '1.23'
 
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Run the bad vote test
         run: go test -timeout 10m -run TestBadVote ./integration/...
   crash:
     name: Test crash
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go ^1.17
-        uses: actions/setup-go@v2
+      - name: Use Go 1.23
+        uses: actions/setup-go@v4
         with:
-          go-version: ^1.17
+          go-version: '1.23'
 
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Run the crash test
-        run: go test -timeout 10m -run TestCrash ./integration/...
+        run: |
+          for a in $( seq 3 ); do
+            echo "Testing sequence $a"
+            go test -timeout 10m -run TestCrash ./integration/... && exit 0
+          done
+          exit 1
   revote:
     name: Test revote
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go ^1.17
-        uses: actions/setup-go@v2
+      - name: Use Go 1.23
+        uses: actions/setup-go@v4
         with:
-          go-version: ^1.17
+          go-version: '1.23'
 
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Run the revote test
         run: go test -timeout 10m -run TestRevote ./integration/...

.github/workflows/go_scenario_test.yml

@@ -11,10 +11,10 @@ jobs:
     name: Tests
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go ^1.17
-        uses: actions/setup-go@v2
+      - name: Use Go 1.23
+        uses: actions/setup-go@v4
         with:
-          go-version: ^1.17
+          go-version: '1.23'
 
       - name: Install crypto util from Dela
         run: |
@@ -23,7 +23,7 @@ jobs:
           go install ./cli/crypto
 
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Create a private key
         run: crypto bls signer new --save private.key

.github/workflows/go_test.yml

@@ -10,52 +10,22 @@ jobs:
     name: Tests
     runs-on: ubuntu-latest
     steps:
-      - name: Use Go >= 1.19
-        uses: actions/setup-go@v3
+      - name: Use Go 1.23
+        uses: actions/setup-go@v4
         with:
-          go-version: '>=1.19'
+          go-version: '1.23'
         id: go
 
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Run lint
-        run: make lint
-
+# TODO: https://github.com/dedis/d-voting/issues/392
+#      - name: Run lint
+#        run: make lint
+#
       - name: Run vet
         run: make vet
 
       - name: Test all, except integration, with coverage
         run: |
-          go test -json -covermode=count -coverprofile=profile.cov $(go list ./... | grep -v /integration) 2>&1 | tee report.json
-
-      - name: Sonarcloud scan
-        uses: sonarsource/sonarcloud-github-action@master
-        with:
-          args: >
-            -Dsonar.organization=dedis
-            -Dsonar.projectKey=dedis_d-voting
-            -Dsonar.go.tests.reportPaths=report.json
-            -Dsonar.go.coverage.reportPaths=profile.cov
-            -Dsonar.coverage.exclusions=**/*_test.go,/internal/**/*
-            -Dsonar.issue.ignore.multicriteria=e1
-            -Dsonar.issue.ignore.multicriteria.e1.ruleKey=*Naming*
-            -Dsonar.issue.ignore.multicriteria.e1.resourceKey=**/*_test.go
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-
-      - name: Send coverage
-        uses: shogo82148/actions-goveralls@v1
-        with:
-          path-to-profile: profile.cov
-          parallel: true
-
-  # notifies that all test jobs are finished.
-  finish:
-    needs: test
-    runs-on: ubuntu-latest
-    steps:
-      - uses: shogo82148/actions-goveralls@v1
-        with:
-          parallel-finished: true
+          go test $(go list ./... | grep -v /integration)

.github/workflows/releases.yml

@@ -11,12 +11,12 @@ jobs:
 
     steps:
       - name: checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Use go
-        uses: actions/setup-go@v3
+      - name: Use Go 1.23
+        uses: actions/setup-go@v4
         with:
-          go-version: '>=1.18'
+          go-version: '1.23'
 
       - name: Install fpm
         run: |

.github/workflows/web_backend_lint.yml

@@ -15,8 +15,8 @@ jobs:
         working-directory: ./web/backend
 
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
+    - uses: actions/checkout@v4
+    - uses: actions/setup-node@v4
       with:
           node-version: '16'
 

.github/workflows/web_frontend_lint.yml

@@ -15,8 +15,8 @@ jobs:
         working-directory: ./web/frontend
 
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
+    - uses: actions/checkout@v4
+    - uses: actions/setup-node@v4
       with:
           node-version: '16'
 

.gitignore

@@ -13,3 +13,9 @@ nodedata/
 
 deb-package/dist/**
 
+.env
+
+dela/
+bin/
+nodes/
+cookies.txt

CHANGELOG.md

@@ -0,0 +1,36 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+Latest changes in each category go to the top
+
+## [Unreleased]
+
+### Added
+- dev_login can change userId when clicking on the user in the upper right
+- admin can now add users as voters
+- New debugging variables in [local_vars.sh](./scripts/local_vars.sh)
+- Changelog - please use it
+
+### Changed
+- for the Dockerfiles and docker-compose.yml, `DELA_NODE_URL` has been replaced with `DELA_PROXY_URL`,
+ which is the more accurate name.
+- the actions in package.json for the frontend changed. Both are somewhat development mode,
+ as the webserver is not supposed to be used in production. 
+  - `start`: starts in plain mode 
+  - `start-https`: starts in HTTPS mode
+
+### Deprecated
+### Removed
+### Fixed
+- Proxy editing fixed: adding, modifying, deleting now works 
+- When fetching form and user updates, only do it when showing the activity
+- Redirection when form doesn't exist and nicer error message
+- File formatting and errors in comments
+- Popup when voting and some voting translation fixes
+- Fixed return error when voting
+
+### Security
+- Use `REACT_APP_RANDOMIZE_VOTE_ID === 'true'` to indicate randomizing vote ids

Dockerfiles/Dockerfile.backend

@@ -3,4 +3,5 @@ FROM node:20-bookworm
 WORKDIR /web/backend
 COPY ../web/backend .
 RUN npm install
-ENTRYPOINT ["/bin/bash", "-c", "npm start"]
+ENTRYPOINT ["npm"]
+CMD ["start"]