Remove unnecessary Arc<T> type #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe and
frankhinek
as code owners
KendallWeihe
commented
May 11, 2024
crates/jws/src/lib.rs
Outdated
| @@ -479,7 +479,8 @@ mod tests { | |||
| &header, | |||
| &payload, | |||
| ) | |||
| .unwrap() + "123"; | |||
| .unwrap() | |||
There was a problem hiding this comment.
interesting, added #200 to try and avoid this in the future
KendallWeihe
force-pushed
the
kendall/198-remove-unnecessary-arc
branch
from
d707058 to
60bd986
Compare
diehuxx
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #198