Remove unnecessary Arc<T> type

decentralized-identity · May 11, 2024 · d707058 · d707058
1 parent b0791f1
commit d707058
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/crates/dids/src/method/jwk.rs b/crates/dids/src/method/jwk.rs
@@ -36,7 +36,7 @@ impl Create<DidJwkCreateOptions> for DidJwk {
         let key_alias = key_manager.generate_private_key(options.curve, Some("0".to_string()))?;
         let public_key = key_manager.get_public_key(&key_alias)?;
         let public_jwk = public_key.jwk()?;
-        let jwk_string = serde_json::to_string(public_jwk.as_ref()).map_err(|_| {
+        let jwk_string = serde_json::to_string(&public_jwk).map_err(|_| {
             MethodError::DidCreationFailure("failed to serialize public jwk".to_string())
         })?;
         let spruce_jwk: SpruceJwk =
@@ -58,7 +58,7 @@ impl Create<DidJwkCreateOptions> for DidJwk {
             id: verification_method_id.clone(),
             r#type: "JsonWebKey".to_string(),
             controller: uri.clone(),
-            public_key_jwk: public_jwk.as_ref().clone(),
+            public_key_jwk: public_jwk.clone(),
         };
 
         let document = Document {

diff --git a/crates/jws/src/lib.rs b/crates/jws/src/lib.rs
@@ -479,7 +479,8 @@ mod tests {
             &header,
             &payload,
         )
-        .unwrap() + "123";
+        .unwrap()
+            + "123";
 
         let result = CompactJws::verify(&compact_jws).await;
 
@@ -520,7 +521,9 @@ mod tests {
             },
         )
         .expect("failed to create bearer did");
-        let invalid_key_id = invalid_bearer_did.document.verification_method[0].id.clone();
+        let invalid_key_id = invalid_bearer_did.document.verification_method[0]
+            .id
+            .clone();
 
         let compact_jws = CompactJws::sign(
             &invalid_bearer_did,

diff --git a/crates/keys/src/key.rs b/crates/keys/src/key.rs
@@ -20,7 +20,7 @@ pub enum KeyError {
 
 pub trait Key: Send + Sync {
     fn alias(&self) -> Result<String, KeyError>;
-    fn jwk(&self) -> Result<Arc<Jwk>, KeyError>;
+    fn jwk(&self) -> Result<Jwk, KeyError>;
 }
 
 pub trait PublicKey: Key + Send + Sync {
@@ -42,8 +42,8 @@ impl Key for Jwk {
         Ok(thumbprint)
     }
 
-    fn jwk(&self) -> Result<Arc<Jwk>, KeyError> {
-        Ok(Arc::new(self.clone()))
+    fn jwk(&self) -> Result<Jwk, KeyError> {
+        Ok(self.clone())
     }
 }