Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/web-create #56

Merged
merged 13 commits into from
Apr 3, 2024
Merged

feature/web-create #56

merged 13 commits into from
Apr 3, 2024

Conversation

fingersonfire
Copy link
Contributor

@fingersonfire fingersonfire commented Mar 29, 2024 •
edited
Loading

Changes in this PR:

  • Updated KeyManager class to include import and export methods by default, I could be wrong but I don't necessarily see a use case where this would be an issue.
  • Added the missing DID resolution results and changed them to factory constructors.
  • Added web did create method and updated the resolver to return notFound result where document location couldn't be resolved and some additional cleanup.
  • Updated the PortableDid to use map instead of json to remove possible confusion (just a nice reminder that the data still has to be encoded if wanted to be used as a .json).
  • Added testing for the web did create function.

Note: The code in this PR relies on additional classes created in the feature/dht-create PR.

@fingersonfire fingersonfire requested a review from mistermoe April 1, 2024 15:41
@michaelneale
Copy link

very cool to see!

@mistermoe
Copy link
Contributor

reviewing first thing tomorrow morning!

@mistermoe
Copy link
Contributor

Updated the PortableDid to use map instead of json to remove possible confusion (just a nice reminder that the data still has to be encoded if wanted to be used as a .json).

Really like this change @StonePack. good call

@mistermoe
Copy link
Contributor

alright awesome! left 3 last comments to address. then we're good to merge 🚀 .

@fingersonfire
Copy link
Contributor Author

Made the suggested changes and fixes

mistermoe
mistermoe approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@mistermoe mistermoe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @StonePack ! onto the did:dht PR

@mistermoe mistermoe merged commit c2d7046 into decentralized-identity:main Apr 3, 2024
1 check passed
@mistermoe mistermoe mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistermoe mistermoe mistermoe approved these changes

@ethanwlee ethanwlee Awaiting requested review from ethanwlee

@kirahsapong kirahsapong Awaiting requested review from kirahsapong

@wesbillman wesbillman Awaiting requested review from wesbillman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fingersonfire @michaelneale @mistermoe