-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/dht-create #55
feature/dht-create #55
Conversation
fingersonfire
commented
Mar 29, 2024
- Same as old PR (hopefully) just with no changes to structure
build failure is just due to Jwk needing to show the thumbprint as alias I think:
This will make it work (in (as it isn't really returning an alias now, but the key). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one! I guess only question is if generate should return key and if so, just update docs and snippet of code to fetch the alias as mentioned.
Very cool!
@StonePack, i just merged #56. lmk once you've rebased or merged main and i'll review. should be able to get this over the line today! |
@mistermoe Should be good to go now, conflicts have been resolved |
good to merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!!