Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test coverage increase in ed25519.ts #815

Merged
merged 2 commits into from
Oct 8, 2024
Merged

feat: test coverage increase in ed25519.ts #815

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5bb4df
feat: test coverage increase in ed25519.ts
ANIRUDH-333 Oct 4, 2024
47c2e3e
refactor: refactored imports t fix lint errors
ANIRUDH-333 Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions tests/jose/jws/general.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
import chai from 'chai';
import chaiAsPromised from 'chai-as-promised';
import chai, { expect } from 'chai';
import { expect } from 'chai';
import sinon from 'sinon';
import { UniversalResolver } from '@web5/dids';

import { ed25519 } from '../../../src/jose/algorithms/signing/ed25519.js';
import { Encoder } from '../../../src/utils/encoder.js';
import { GeneralJwsBuilder } from '../../../src/jose/jws/general/builder.js';
import { GeneralJwsVerifier } from '../../../src/jose/jws/general/verifier.js';
import { Jws } from '../../../src/utils/jws.js';
import { PrivateKeySigner } from '../../../src/index.js';
import { signatureAlgorithms } from '../../../src/jose/algorithms/signing/signature-algorithms.js';
import sinon from 'sinon';
import { UniversalResolver } from '@web5/dids';
import { DwnError, DwnErrorCode } from '../../../src/core/dwn-error.js';


const { Ed25519, secp256k1 } = signatureAlgorithms;
const secp256r1 = signatureAlgorithms['P-256'];
Expand Down Expand Up @@ -124,6 +129,34 @@ describe('General JWS Sign/Verify', () => {
expect(verificationResult.signers).to.include('did:jank:alice');
});

it('should throw an error for invalid Ed25519 JWK', async () => {
const invalidJwk = {
kty : 'RSA', // Invalid key type
crv : 'Ed25519',
d : 'invalid-private-key'
};

const content = new TextEncoder().encode('anyPayloadValue');

try {
await ed25519.sign(content, invalidJwk as any);
expect.fail('Expected an error to be thrown');
} catch (error) {
expect(error).to.be.instanceOf(DwnError);
expect((error as DwnError).code).to.equal(DwnErrorCode.Ed25519InvalidJwk);
expect((error as DwnError).message).to.include('invalid jwk. kty MUST be OKP. crv MUST be Ed25519');
}
});

it('should convert public key bytes to JWK', async () => {
const { publicJwk } = await ed25519.generateKeyPair();
const publicKeyBytes = Encoder.base64UrlToBytes(publicJwk.x);

const convertedJwk = await ed25519.publicKeyToJwk(publicKeyBytes);

expect(convertedJwk).to.deep.equal(publicJwk);
});

it('should support multiple signatures using different key types', async () => {
const secp256k1Keys = await secp256k1.generateKeyPair();
const ed25519Keys = await Ed25519.generateKeyPair();
Expand Down