-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test coverage increase in ed25519.ts #815
feat: test coverage increase in ed25519.ts #815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎖️ 🚀 🙏
I can try to fix the lint error but not sure why the 1st one is failing. |
Fixed the linter issues. Can you please review again @thehenrytsai ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
==========================================
+ Coverage 98.71% 98.76% +0.04%
==========================================
Files 74 74
Lines 11469 11508 +39
Branches 1652 1662 +10
==========================================
+ Hits 11322 11366 +44
+ Misses 141 136 -5
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Hii @mistermoe , @csuwildcat , @thehenrytsai , @LiranCohen. Could you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐐 🚀
Resolves #136
Completely covers the
ed25519.ts
file with 100% coverage.