Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test coverage increase in ed25519.ts #815

Merged

Conversation

ANIRUDH-333
Copy link
Contributor

@ANIRUDH-333 ANIRUDH-333 commented Oct 4, 2024

Resolves #136
Completely covers the ed25519.ts file with 100% coverage.

File Name Statements Branches Functions Lines
Before:
All files 99.05 97.55 96.04 99.05
ed25519.ts 93.1 88.88 83.33 93.1
After:
All files 99.09 97.6 96.25 99.09
ed25519.ts 100 100 100 100

thehenrytsai
thehenrytsai previously approved these changes Oct 4, 2024
Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️ 🚀 🙏

@ANIRUDH-333
Copy link
Contributor Author

I can try to fix the lint error but not sure why the 1st one is failing.

@ANIRUDH-333
Copy link
Contributor Author

ANIRUDH-333 commented Oct 5, 2024

Fixed the linter issues. Can you please review again @thehenrytsai ?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (8b6eb13) to head (47c2e3e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
+ Coverage   98.71%   98.76%   +0.04%     
==========================================
  Files          74       74              
  Lines       11469    11508      +39     
  Branches     1652     1662      +10     
==========================================
+ Hits        11322    11366      +44     
+ Misses        141      136       -5     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ANIRUDH-333
Copy link
Contributor Author

Hii @mistermoe , @csuwildcat , @thehenrytsai , @LiranCohen. Could you please review this?

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐 🚀

@LiranCohen LiranCohen merged commit 30f8b69 into decentralized-identity:main Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase code coverage (even if just by a little bit)
4 participants