-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simple cleanup #6173
base: dev
Are you sure you want to change the base?
chore: simple cleanup #6173
Conversation
b490478
to
f277c4d
Compare
Hi, thanks for this contribution, this is really nice clean up. We will check it, as we need to run some checks first. |
5292d10
to
f277c4d
Compare
Obviously this cleanup is not that simple... |
f277c4d
to
177d4e0
Compare
Moved this code-duplication removal to its own PR, in the meantime, it should be possible to merge these remaining two simple cleanups. |
Could you describe why you are making this changes? Could you follow this guide https://github.com/decentraland/unity-renderer/blob/dev/.github/CONTRIBUTING.md |
I do believe I have been following the |
@@ -1,7 +1,7 @@ | |||
############################################################################### | |||
# Set default behavior to automatically normalize line endings. | |||
############################################################################### | |||
* text=auto | |||
* text=auto eol=lf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On all modern OSes, modern editors (including VS Code) can deal with lf
endings just fine, crlf
is not needed.
If git
is allowed to set the line endings to crlf
before commits, this leads to discrepancies that are annoyingly useless at best.
And who knows what at worse ! Some of these files end up being used in a Docker environment, which will be expecting lf
endings.
@@ -82,6 +82,7 @@ test/**/*.js | |||
test/**/*.js.map | |||
dist | |||
!packages/shared/world/runtime-7/sourcemap/[email protected] | |||
/protocol-temp/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This folder can remain if the build process is interrupted before the end.
Its brief appearance has also been confusing my own file monitoring process.
What does this PR change?