Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simple cleanup #6173

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

chore: simple cleanup #6173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58a5fad
chore: include browser-interface/protocol-temp/ in .gitignore
ProteanCoding Mar 20, 2024
177d4e0
chore: facilitate Docker sharing the Windows directory with eol=lf
ProteanCoding Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
###############################################################################
# Set default behavior to automatically normalize line endings.
###############################################################################
* text=auto
* text=auto eol=lf
Copy link
Author

@ProteanCoding ProteanCoding Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On all modern OSes, modern editors (including VS Code) can deal with lf endings just fine, crlf is not needed.
If git is allowed to set the line endings to crlf before commits, this leads to discrepancies that are annoyingly useless at best.

And who knows what at worse ! Some of these files end up being used in a Docker environment, which will be expecting lf endings.


###############################################################################
# Set default behavior for command prompt diff.
Expand Down
1 change: 1 addition & 0 deletions browser-interface/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ test/**/*.js
test/**/*.js.map
dist
!packages/shared/world/runtime-7/sourcemap/[email protected]
/protocol-temp/
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder can remain if the build process is interrupted before the end.
Its brief appearance has also been confusing my own file monitoring process.


# ============== #
# Local mappings #
Expand Down
Loading