-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): split out temp wheel builds #12157
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3da8ca7
feat(python): split out temp wheel builds
hsheth2 842fc68
fix action
hsheth2 f3d7549
tweak build
hsheth2 606e53f
fix bug
hsheth2 4ad1f76
add name
hsheth2 8ace27c
tweaks
hsheth2 ff5fe51
tweak upload
hsheth2 9d40146
Merge branch 'master' into fast-wheel-builds
hsheth2 3e4bdb9
add build context
hsheth2 7340ae3
add relative timestamps
hsheth2 441a055
add env
hsheth2 4352685
add debug command
hsheth2 413c450
fix
hsheth2 d633413
better detection in ci
hsheth2 37127da
add pr read permissions
hsheth2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| name: Python Build | ||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| paths: | ||
| - ".github/workflows/python-build-pages.yml" | ||
| - "metadata-ingestion/**" | ||
| - "metadata-ingestion-modules/**" | ||
| - "metadata-models/**" | ||
| pull_request: | ||
| branches: | ||
| - "**" | ||
| paths: | ||
| - ".github/workflows/python-build-pages.yml" | ||
| - "metadata-ingestion/**" | ||
| - "metadata-ingestion-modules/**" | ||
| - "metadata-models/**" | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| deploy-pages: | ||
| runs-on: ubuntu-latest | ||
| if: ${{ vars.CLOUDFLARE_WHEELS_PROJECT_NAME != '' }} | ||
|
|
||
| name: Python Wheels | ||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
| deployments: write | ||
| steps: | ||
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: "zulu" | ||
| java-version: 17 | ||
| - uses: gradle/actions/setup-gradle@v3 | ||
| - uses: acryldata/sane-checkout-action@v3 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.10" | ||
| cache: "pip" | ||
| - uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.cache/uv | ||
| key: ${{ runner.os }}-uv-${{ hashFiles('**/requirements.txt') }} | ||
| - name: Build Python wheel site | ||
| run: | | ||
| ./gradlew :python-build:buildSite | ||
| env: | ||
| GITHUB_TOKEN: ${{ github.token }} | ||
| - name: Publish | ||
| uses: cloudflare/pages-action@v1 | ||
| with: | ||
| apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }} | ||
| accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} | ||
| projectName: ${{ vars.CLOUDFLARE_WHEELS_PROJECT_NAME }} | ||
| workingDirectory: python-build | ||
| directory: site | ||
| gitHubToken: ${{ github.token }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
|
|
||
| /wheels | ||
| /site |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| plugins { | ||
| id 'base' | ||
| } | ||
|
|
||
| ext { | ||
| python_executable = 'python3' | ||
| } | ||
|
|
||
| task checkPythonVersion(type: Exec) { | ||
| commandLine python_executable, '-c', | ||
| 'import sys; sys.version_info >= (3, 8), f"Python version {sys.version_info} is too old"' | ||
| } | ||
|
|
||
| task buildWheels(type: Exec, dependsOn: [ | ||
| checkPythonVersion, | ||
| ':metadata-ingestion:buildWheel', | ||
| ':metadata-ingestion-modules:airflow-plugin:buildWheel', | ||
| ':metadata-ingestion-modules:dagster-plugin:buildWheel', | ||
| ':metadata-ingestion-modules:prefect-plugin:buildWheel', | ||
| ':metadata-ingestion-modules:gx-plugin:buildWheel', | ||
| ]) { | ||
| commandLine python_executable, "copy_wheels.py" | ||
| } | ||
|
|
||
| task buildSite(type: Exec, dependsOn: [buildWheels]) { | ||
| commandLine python_executable, "build_site.py" | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
copy_wheels.pyscript could be replaced with an inlinersynccommand. This change would bring the list of directories to be synced closer to the gradle dependencies of the task, reducing the risk of misalignment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup - will note that down for a follow up