-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): split out temp wheel builds #12157
Conversation
isn't that the usual way of working? |
@sgomezvillamor I primarily create branches on the datahub-project/datahub repo, and other folks with committer access can do the same. This has other benefits e.g. cypress cloud will show logs of exactly what tests failed and will show screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just minor suggestions
':metadata-ingestion-modules:prefect-plugin:buildWheel', | ||
':metadata-ingestion-modules:gx-plugin:buildWheel', | ||
]) { | ||
commandLine python_executable, "copy_wheels.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy_wheels.py
script could be replaced with an inline rsync
command. This change would bring the list of directories to be synced closer to the gradle dependencies of the task, reducing the risk of misalignment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup - will note that down for a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit hash, commit message, branch name... all this info is available in the github actions context.
We can pass these details as arguments to the gradle build, which would streamline this script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we pull some of these from the github env variable context. however, I wanted it to work similarly across local dev and CI, so we have both variants
This should enable wheels to be available within ~2 minutes of the commit, which is significantly faster than the ~18 minutes we currently get with Vercel builds.
The new site also comes with a nicer index page, which gives you a brief tutorial on how to use it.
The new dedicated Python wheels site is deployed with Cloudflare pages, which means it will not be generated for PRs from forks. We can look into using
pull_request_target
for those in the future.I intend to remove Python wheels from the docs site in the future, once this change has baked for a while.
This PR also updates our CI pipelines across our Python builds - upgrading versions, fixing various bugs with flags, etc
Checklist