Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git): add subdir support to GitReference #12131

Merged
merged 6 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion metadata-ingestion/src/datahub/configuration/git.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ class GitReference(ConfigModel):
"main",
description="Branch on which your files live by default. Typically main or master. This can also be a commit hash.",
)

url_subdir: Optional[str] = Field(
default=None,
description="Prefix to prepend when generating URLs for files - useful when files are in a subdirectory. "
"Only affects URL generation, not git operations.",
)
url_template: Optional[str] = Field(
None,
description=f"Template for generating a URL to a file in the repo e.g. '{_GITHUB_URL_TEMPLATE}'. We can infer this for GitHub and GitLab repos, and it is otherwise required."
Expand Down Expand Up @@ -68,6 +72,8 @@ def infer_url_template(cls, url_template: Optional[str], values: dict) -> str:

def get_url_for_file_path(self, file_path: str) -> str:
assert self.url_template
if self.url_subdir:
file_path = f"{self.url_subdir}/{file_path}"
return self.url_template.format(
repo_url=self.repo, branch=self.branch, file_path=file_path
)
Expand Down
35 changes: 31 additions & 4 deletions metadata-ingestion/tests/integration/git/test_git_clone.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
import pathlib

import pytest
from pydantic import SecretStr
Expand All @@ -12,7 +13,7 @@
LOOKML_TEST_SSH_KEY = os.environ.get("DATAHUB_LOOKML_GIT_TEST_SSH_KEY")


def test_base_url_guessing():
def test_base_url_guessing() -> None:
# Basic GitHub repo.
config = GitInfo(repo="https://github.com/datahub-project/datahub", branch="master")
assert config.repo_ssh_locator == "[email protected]:datahub-project/datahub.git"
Expand Down Expand Up @@ -70,7 +71,7 @@ def test_base_url_guessing():
)


def test_github_branch():
def test_github_branch() -> None:
config = GitInfo(
repo="owner/repo",
)
Expand All @@ -83,11 +84,37 @@ def test_github_branch():
assert config.branch_for_clone == "main"


def test_url_subdir() -> None:
git_ref = GitReference(repo="https://github.com/org/repo", url_subdir="dbt")
assert (
git_ref.get_url_for_file_path("model.sql")
== "https://github.com/org/repo/blob/main/dbt/model.sql"
)

git_ref = GitReference(repo="https://gitlab.com/org/repo", url_subdir="dbt")
assert (
git_ref.get_url_for_file_path("model.sql")
== "https://gitlab.com/org/repo/-/blob/main/dbt/model.sql"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with gitlab and this - in the middle called my attention.

Apparently, the dashless variant also works https://gitlab.com/gitlab-org/gitlab/-/issues/365984

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh interesting

The /-/ stuff was already in there, and given that it still works, I don't think it makes sense to change right now

)

git_ref = GitReference(repo="https://github.com/org/repo", url_subdir="")
assert (
git_ref.get_url_for_file_path("model.sql")
== "https://github.com/org/repo/blob/main/model.sql"
)

git_ref = GitReference(repo="https://github.com/org/repo", url_subdir="dbt/models")
assert (
git_ref.get_url_for_file_path("model.sql")
== "https://github.com/org/repo/blob/main/dbt/models/model.sql"
)


def test_sanitize_repo_url() -> None:
assert_doctest(datahub.ingestion.source.git.git_import)


def test_git_clone_public(tmp_path):
def test_git_clone_public(tmp_path: pathlib.Path) -> None:
git_clone = GitClone(str(tmp_path))
checkout_dir = git_clone.clone(
ssh_key=None,
Expand All @@ -107,7 +134,7 @@ def test_git_clone_public(tmp_path):
LOOKML_TEST_SSH_KEY is None,
reason="DATAHUB_LOOKML_GIT_TEST_SSH_KEY env variable is not configured",
)
def test_git_clone_private(tmp_path):
def test_git_clone_private(tmp_path: pathlib.Path) -> None:
git_clone = GitClone(str(tmp_path))
secret_key = SecretStr(LOOKML_TEST_SSH_KEY) if LOOKML_TEST_SSH_KEY else None

Expand Down
Loading