feat(git): add subdir support to GitReference #12131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add subdir field to GitReference class for specifying subdirectory - Update get_url_for_file_path to handle subdir correctly - Add test cases for both GitHub and GitLab URL generation Co-Authored-By: [email protected] <[email protected]>
…tation Co-Authored-By: [email protected] <[email protected]>
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
| git_ref = GitReference(repo="https://gitlab.com/org/repo", url_subdir="dbt") | ||
| assert ( | ||
| git_ref.get_url_for_file_path("model.sql") | ||
| == "https://gitlab.com/org/repo/-/blob/main/dbt/model.sql" |
There was a problem hiding this comment.
I'm not familiar with gitlab and this - in the middle called my attention.
Apparently, the dashless variant also works https://gitlab.com/gitlab-org/gitlab/-/issues/365984
There was a problem hiding this comment.
huh interesting
The /-/ stuff was already in there, and given that it still works, I don't think it makes sense to change right now
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist