-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datahub-client): additionally generates java8 artefacts #12106
Merged
sgomezvillamor
merged 3 commits into
datahub-project:master
from
sgomezvillamor:feat-datahub-client-java8
Dec 12, 2024
Merged
feat(datahub-client): additionally generates java8 artefacts #12106
sgomezvillamor
merged 3 commits into
datahub-project:master
from
sgomezvillamor:feat-datahub-client-java8
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
PR or Issue related to the ingestion of metadata
devops
PR or Issue related to DataHub backend & deployment
labels
Dec 12, 2024
Den tors 12 dec. 2024 09:15Sergio Gómez Villamor ***@***.***>
skrev:
… Successfully tested locally
$ ./gradlew :metadata-integration:java:datahub-client:jar :metadata-integration:java:datahub-client:shadowJar -PjavaClassVersionDefault=8 -ParchiveAppendix=java8
...
$ ls metadata-integration/java/datahub-client/build/libs
datahub-client-java8-0.15.0rc16-SNAPSHOT-lib.jar datahub-client-java8-0.15.0rc16-SNAPSHOT.jar
Checklist
- The PR conforms to DataHub's Contributing Guideline
<https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md>
(particularly Commit Message Format
<https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md#commit-message-format>
)
- Links to related issues (if applicable)
- Tests for the changes have been added/updated (if applicable)
- Docs related to the changes have been added/updated (if applicable).
If a new feature has been added a Usage Guide has been added for the same.
- For any breaking change/potential downtime/deprecation/big changes
an entry has been made in Updating DataHub
<https://github.com/datahub-project/datahub/blob/master/docs/how/updating-datahub.md>
------------------------------
You can view, comment on, or merge this pull request online at:
#12106
Commit Summary
- a235da4
<a235da4>
feat(datahub-client): additionally generates java8 artefacts
File Changes
(2 files <https://github.com/datahub-project/datahub/pull/12106/files>)
- *M* .github/workflows/publish-datahub-jars.yml
<https://github.com/datahub-project/datahub/pull/12106/files#diff-0f5b57324cc1600e23b57e0719a64515301e90ea92d79cc4f13540f39ac1c73c>
(49)
- *M* metadata-integration/java/datahub-client/build.gradle
<https://github.com/datahub-project/datahub/pull/12106/files#diff-395a9c4fdd8650444b6c1a95c08e4abf31c82055f17b50ff2e3df5326cd4bc5f>
(6)
Patch Links:
- https://github.com/datahub-project/datahub/pull/12106.patch
- https://github.com/datahub-project/datahub/pull/12106.diff
—
Reply to this email directly, view it on GitHub
<#12106>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLQW5VC3OKPVM7AG4UIOPLT2FFA3PAVCNFSM6AAAAABTPGQJEWVHI2DSMVQWIX3LMV43ASLTON2WKOZSG4ZTKMJXGI2TQMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This was referenced Dec 12, 2024
datahub-cyborg
bot
added
the
needs-review
Label for PRs that need review from a maintainer.
label
Dec 12, 2024
david-leifker
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
Label for PRs that need review from a maintainer.
labels
Dec 12, 2024
sgomezvillamor
merged commit Dec 12, 2024
edca8ea
into
datahub-project:master
50 of 51 checks passed
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
PR or Issue related to DataHub backend & deployment
ingestion
PR or Issue related to the ingestion of metadata
pending-submitter-merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully tested locally
Checklist