Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datahub-client): additionally generates java8 artefacts #12106

Merged

Conversation

sgomezvillamor
Copy link
Contributor

Successfully tested locally

$ ./gradlew :metadata-integration:java:datahub-client:jar :metadata-integration:java:datahub-client:shadowJar -PjavaClassVersionDefault=8 -ParchiveAppendix=java8
...
$ ls metadata-integration/java/datahub-client/build/libs 
datahub-client-java8-0.15.0rc16-SNAPSHOT-lib.jar datahub-client-java8-0.15.0rc16-SNAPSHOT.jar

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata devops PR or Issue related to DataHub backend & deployment labels Dec 12, 2024
@Daniellundin048
Copy link

Daniellundin048 commented Dec 12, 2024 via email

Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 12, 2024
@sgomezvillamor sgomezvillamor enabled auto-merge (squash) December 12, 2024 13:47
@sgomezvillamor sgomezvillamor merged commit edca8ea into datahub-project:master Dec 12, 2024
50 of 51 checks passed
@sgomezvillamor sgomezvillamor deleted the feat-datahub-client-java8 branch December 12, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants