Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sets default java class version 8 #12095

Closed
wants to merge 1 commit into from
Closed

feat: sets default java class version 8 #12095

wants to merge 1 commit into from

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Dec 11, 2024 •
edited
Loading

Some external consumer of the DataHub's Java Client SDK, eg Hudi project, requires java 8 compatible binaries.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

david-leifker
david-leifker requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not do this. The entire project, gms, consumers, etc, will break.

@sgomezvillamor
Copy link
Contributor Author

Superseded by #12106

@sgomezvillamor sgomezvillamor deleted the feat-default-java-class-version-8 branch December 12, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgomezvillamor @david-leifker