Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Column.len, which returns Scalar, instead of Column.__len__ (returning int) #331

Merged
merged 2 commits into from
Dec 7, 2023
Merged

add Column.len, which returns Scalar, instead of Column.__len__ (returning int) #331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb1daa6
add Column.len
MarcoGorelli Nov 21, 2023
e2c8542
Merge branch 'main' into column-len
MarcoGorelli Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spec/API_specification/dataframe_api/column_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,6 @@ def name(self) -> str:
"""Return name of column."""
...

def __len__(self) -> int:
"""Return the number of rows."""
...

def __iter__(self) -> NoReturn:
"""Iterate over elements.

Expand Down Expand Up @@ -750,6 +746,10 @@ def var(
"""
...

def len(self) -> Scalar:
"""Return the number of rows."""
...

def n_unique(self, *, skip_nulls: bool = True) -> Scalar:
"""Return number of unique values.

Expand Down